From: David Lechner <david@lechnology.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH v3] leds: Introduce userspace leds driver
Date: Fri, 16 Sep 2016 10:41:20 -0500 [thread overview]
Message-ID: <a3a5c492-3c9a-9fd6-a601-c4fd6bcd3106@lechnology.com> (raw)
In-Reply-To: <20160916060718.GD13205@amd>
On 09/16/2016 01:07 AM, Pavel Machek wrote:
> Hi!
>
> +static ssize_t uleds_read(struct file *file, char __user *buffer,
> size_t count,
> + loff_t *ppos)
> +{
> + struct uleds_device *udev = file->private_data;
> + ssize_t retval;
> +
> + if (count == 0)
> + return 0;
> +
> + if (count != 1)
> + return -EINVAL;
>
> This is quite anti-social. You are free to return 1 byte on any read
> (short read), but please allow reads with bigger buffers.
>
> Thanks,
> Pavel
>
Sure.
next prev parent reply other threads:[~2016-09-16 15:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 16:49 David Lechner
[not found] ` <alpine.LRH.2.20.1609091525060.22407@federalhill.net>
2016-09-09 20:44 ` David Lechner
[not found] ` <CGME20160912081846eucas1p255044e49034685ad44400d6830ef0b95@eucas1p2.samsung.com>
2016-09-12 8:18 ` Jacek Anaszewski
2016-09-12 14:58 ` David Lechner
2016-09-15 13:08 ` Pavel Machek
2016-09-15 13:35 ` Pavel Machek
2016-09-15 14:54 ` Jacek Anaszewski
2016-09-16 6:09 ` Pavel Machek
2016-09-15 14:54 ` Jacek Anaszewski
2016-09-15 15:31 ` David Lechner
2016-09-15 15:35 ` David Lechner
2016-09-16 5:51 ` Pavel Machek
2016-09-16 15:18 ` David Lechner
2016-09-16 5:59 ` Pavel Machek
2016-09-16 15:32 ` David Lechner
2016-09-16 6:07 ` Pavel Machek
2016-09-16 15:41 ` David Lechner [this message]
2016-09-15 16:34 ` David Lechner
2016-09-16 5:50 ` Pavel Machek
2016-09-16 7:07 ` Jacek Anaszewski
2016-09-16 15:09 ` David Lechner
2016-09-16 19:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a5c492-3c9a-9fd6-a601-c4fd6bcd3106@lechnology.com \
--to=david@lechnology.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®