Re: [PATCH 1/2] open: new O_REGULAR flag support

["Arnd Bergmann" <arnd@arndb.de>]

On Sun, Jan 25, 2026, at 16:41, Dorjoy Chowdhury wrote:
>
> Thanks for pointing this out. I will fix up in v2 along with other
> comments (if any). I looked at the existing error codes in
> uapi/asm-generic/errno.h and didn't notice anything that I could
> reuse. So if I understand correctly, I will need this new error code
> in both uapi/asm-generic/errno.h (not in errno-base.h) and in
> arch/*/include/uapi/asm/errno.h (I see some parallel
> tools/arch/*/include/uapi/asm/errno.h files too) just after EHWPOISON,
> right?

Yes, sounds good to me.

>> > diff --git a/include/uapi/asm-generic/fcntl.h b/include/uapi/asm-generic/fcntl.h
>> > index 613475285643..11e5eadab868 100644
>> > --- a/include/uapi/asm-generic/fcntl.h
>> > +++ b/include/uapi/asm-generic/fcntl.h
>> > @@ -88,6 +88,10 @@
>> >  #define __O_TMPFILE  020000000
>> >  #endif
>> >
>> > +#ifndef O_REGULAR
>> > +#define O_REGULAR       040000000
>> > +#endif
>>
>> This in turn clashes with O_PATH on alpha, __O_TMPFILE on
>> parisc, and __O_SYNC on sparc. We can probably fill the holes
>> in asm/fcntl.h to define this.
>>
>
> And for this, I will need to just define O_REGULAR in alpha, parisc
> and sparc too, right?

Yes, the only question is whether to use the first available
bit, or the one after the previously last one.

> Good catch on the sparc file, some are octal, some are hexadecimal,
> easy to miss. Thanks!

Right, I wonder if there are any downsides to redefining them
all the same way.

    Arnd