From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17CBC07E96 for ; Thu, 8 Jul 2021 09:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C040661A33 for ; Thu, 8 Jul 2021 09:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbhGHJgv (ORCPT ); Thu, 8 Jul 2021 05:36:51 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34758 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbhGHJgt (ORCPT ); Thu, 8 Jul 2021 05:36:49 -0400 Received: from mail-wm1-f72.google.com ([209.85.128.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1m1QQ3-0006cT-6k for linux-kernel@vger.kernel.org; Thu, 08 Jul 2021 09:34:07 +0000 Received: by mail-wm1-f72.google.com with SMTP id p3-20020a05600c3583b02901f55d71e34aso2134323wmq.4 for ; Thu, 08 Jul 2021 02:34:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E0C7nCPw9ngmgHYShx7ewbeQGAOF1fcpotAi0fhHmT0=; b=gCaZ/tathkmvFbhMiUmx8Z68+6H25HlQdjfhAfo3FIvBORNp8q2iIboYt3eV475d8j niJkZa6Q9Wg/nSOFGxDXVMy/4hs/mXVugCBLbyOonnaAxZLf6NtflgDP4JzC1CEQRmVC O3v5XwONE/a5YIBHOg3gnc/PlIT+x3heKurDYwbKBrHKE2gqIYeNx8wgAgNjrxoftNe4 ZjaumrhJsWX5wKhNuArJazIWkJJIVFzRo/D9mq10/RxvroCDeDsD4m4xNn0+sJGI4IgN ZX6BoSo6sVqa32KVd0qi42oja9khNcEGpDofLXQeH7nK56bA2HOPUjY5g0E92Y2GSHPU peVQ== X-Gm-Message-State: AOAM530MRiqp5x9f+FYUeQvD1MY2C4vs6BrqwNvdC3piPDk6L0xL66xD neeYO+wjRVAp0T58JkGYMFhIDf4zpy+mAmCS2nEoNg2rbkUC8xruOf8AeBOimfp7pAAhD5bfpWN WuowCi6RmI5bfuqvq4PKNesa+77TkFZjVlFEJm3RIMw== X-Received: by 2002:a05:6000:12c7:: with SMTP id l7mr32033339wrx.177.1625736846964; Thu, 08 Jul 2021 02:34:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6b2RvxjwXvMJgFoy20i+dUp4HtIQ58rbfVrXOuRcq9Ho/OovvbcDwRF9C+0n3tuxHzLL9uQ== X-Received: by 2002:a05:6000:12c7:: with SMTP id l7mr32033308wrx.177.1625736846800; Thu, 08 Jul 2021 02:34:06 -0700 (PDT) Received: from [192.168.3.211] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id p7sm1637544wrr.21.2021.07.08.02.34.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 02:34:06 -0700 (PDT) Subject: Re: [PATCH 4/9] memory: mtk-smi: Rename smi_gen to smi_type To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com References: <20210616114346.18812-1-yong.wu@mediatek.com> <20210616114346.18812-5-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: Date: Thu, 8 Jul 2021 11:34:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210616114346.18812-5-yong.wu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2021 13:43, Yong Wu wrote: > This is a preparing patch for adding smi sub common. Don't write "This patch". Use simple imperative: "Prepare for adding smi sub common." https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L89 > About the previou smi_gen, we have gen1/gen2 that stand for the generation > number for HW. I plan to add a new type(sub_common), then the "gen" is not > prober. this patch only change it to "type", No functional change. Same. > > Signed-off-by: Yong Wu > --- > drivers/memory/mtk-smi.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > Best regards, Krzysztof