From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: wangweidong.a@awinic.com, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
perex@perex.cz, tiwai@suse.com, rf@opensource.cirrus.com,
herve.codina@bootlin.com, shumingf@realtek.com,
rdunlap@infradead.org, 13916275206@139.com, ryans.lee@analog.com,
linus.walleij@linaro.org, ckeepax@opensource.cirrus.com,
yijiangtao@awinic.com, liweilei@awinic.com,
colin.i.king@gmail.com, trix@redhat.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: zhangjianming@awinic.com
Subject: Re: [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390"
Date: Mon, 4 Sep 2023 14:14:31 +0200 [thread overview]
Message-ID: <a3ada071-4c8e-f65d-ad75-655370ba2c55@linaro.org> (raw)
In-Reply-To: <20230904114621.4457-2-wangweidong.a@awinic.com>
On 04/09/2023 13:46, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> Add a DT schema for describing awinic aw87390 audio amplifiers.
> They are controlled using I2C.
Thank you for your patch. There is something to discuss/improve.
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: awinic,aw87390
> +
> + reg:
> + maxItems: 1
No reset-gpios? Shouldn't this be just merged with awinic,aw88395 bindings?
Missing sound-dai-cells (const: 0 or 1)
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + audio-codec@58 {
> + compatible = "awinic,aw87390";
> + reg = <0x58>;
Please add sound-dai-cells for the example to be complete.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-04 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 11:46 [PATCH V1 0/3] ASoC: codecs: Add aw87390 amplifier driver wangweidong.a
2023-09-04 11:46 ` [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390" wangweidong.a
2023-09-04 12:14 ` Krzysztof Kozlowski [this message]
2023-09-05 3:31 ` wangweidong.a
2023-09-05 6:33 ` Krzysztof Kozlowski
2023-09-04 11:46 ` [PATCH V1 2/3] ASoC: codecs: Add code for bin parsing compatible with aw87390 wangweidong.a
2023-09-04 11:46 ` [PATCH V1 3/3] ASoC: codecs: Add aw87390 amplifier driver wangweidong.a
2023-09-04 12:17 ` Krzysztof Kozlowski
2023-09-04 12:30 ` Mark Brown
2023-09-04 13:02 ` Krzysztof Kozlowski
2023-09-04 14:54 ` Mark Brown
2023-09-04 20:26 ` Linus Walleij
2023-09-05 6:03 ` wangweidong.a
2023-09-04 20:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ada071-4c8e-f65d-ad75-655370ba2c55@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=ryans.lee@analog.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
--cc=zhangjianming@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®