From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED777C433E0 for ; Fri, 12 Mar 2021 16:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC6F964FF5 for ; Fri, 12 Mar 2021 16:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231789AbhCLP7d (ORCPT ); Fri, 12 Mar 2021 10:59:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231519AbhCLP7G (ORCPT ); Fri, 12 Mar 2021 10:59:06 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B067DC061574 for ; Fri, 12 Mar 2021 07:59:05 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id j2so5076477wrx.9 for ; Fri, 12 Mar 2021 07:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gefUvqZ+PVzm20AG/CnQcxDANW6owChYqRkVVyHl7s0=; b=gCauilkWy0v9euw5fGyJ7PnNGhvzAnprPg5JozU2kmU3KtD57PebSfGk/6Fp4K57qv cfyuxdLmO34VZiAMY6P/vRYAKmn/9jJvpcpD+6BBIBTVo6F8YpXi+SPxanEennMvJ02u JRvRi8yzoOvQQHRJKQovQlhm0QvdhlGnRoM7KkE6Kdlk70l60XVvE0xjTUGvcfzksipK yl1+rjSLP9sTY2Ma7L8/0dUE2P8NmKUZNja0xXv3GzPZa8f4r3iS76sCY7KAbb0Ns8/h ni2krnPqS6qM0kld3sRBDVKGBFHgnC4YyiSyENf5p7DAd9UdMa3inWXss08e1TW7xwBR Tpfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gefUvqZ+PVzm20AG/CnQcxDANW6owChYqRkVVyHl7s0=; b=rXKrQBPYLv+jwwf6gtEczCUeXfJrZi9tIqvwF7DE5WUYViGZSSEdHLkNQ8MpDc1i3v 33RSXcQDk50JHJiRZY3E1ENuco2QrOwE/jSeMOmDU17OJe+E3DZS21+2RC9lQ4WSuNZE 5fPQSJiKzAlpD4KS3iN91jFYmrDAtGktnmkOj50EqOZd+jWmd+ZFspnjg/94RwJKQAcr 8tJSCa9SW50NktlVPwYxEEE5SFUIaaIKOZ9NcfCQ+8etG8UKapmQft2T6qsEVb4DC7Rw S7ZPdpSIFHJtLlhGdu5nHl0BcjZeguCi5USVGcjCJpsB94DDniudwJrVsy2f115OcuL5 4W5g== X-Gm-Message-State: AOAM532Y3K0R6eXn7bb3GaFCWlD3naqRQeoOPUNeme9+8an2yKpCGkZR 7PjVVl61yKB3JcsMX+8kkDQ= X-Google-Smtp-Source: ABdhPJx5sRlKADvu2Mizzkmg4c61CPj3z3qQQIUzLt3LLT74J7waTqUFNKJKoVz4iRURyFQlW4Ebvg== X-Received: by 2002:adf:f94c:: with SMTP id q12mr14441265wrr.283.1615564744526; Fri, 12 Mar 2021 07:59:04 -0800 (PST) Received: from agape.jhs ([5.171.80.73]) by smtp.gmail.com with ESMTPSA id s16sm8267410wru.91.2021.03.12.07.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 07:59:04 -0800 (PST) Date: Fri, 12 Mar 2021 16:58:58 +0100 From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: rtl8723bs: remove unused code blocks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org remove conditional code blocks checked by unused CONFIG_TCP_CSUM_OFFLOAD_RX cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 5 ----- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 8 -------- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h index b4aeb44d5d6e..078854a55a31 100644 --- a/drivers/staging/rtl8723bs/include/rtw_recv.h +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h @@ -159,11 +159,6 @@ struct rx_pkt_attrib { u8 ack_policy; -/* ifdef CONFIG_TCP_CSUM_OFFLOAD_RX */ - u8 tcpchk_valid; /* 0: invalid, 1: valid */ - u8 ip_chkrpt; /* 0: incorrect, 1: correct */ - u8 tcp_chkrpt; /* 0: incorrect, 1: correct */ -/* endif */ u8 key_index; u8 data_rate; diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c index f52802f24466..78d5b6913467 100644 --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c @@ -138,15 +138,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt pkt->protocol = eth_type_trans(pkt, padapter->pnetdev); pkt->dev = padapter->pnetdev; -#ifdef CONFIG_TCP_CSUM_OFFLOAD_RX - if ((pattrib->tcpchk_valid == 1) && (pattrib->tcp_chkrpt == 1)) - pkt->ip_summed = CHECKSUM_UNNECESSARY; - else - pkt->ip_summed = CHECKSUM_NONE; - -#else /* !CONFIG_TCP_CSUM_OFFLOAD_RX */ pkt->ip_summed = CHECKSUM_NONE; -#endif /* CONFIG_TCP_CSUM_OFFLOAD_RX */ ret = rtw_netif_rx(padapter->pnetdev, pkt); } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B129CC43381 for ; Fri, 12 Mar 2021 16:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E7D16500F for ; Fri, 12 Mar 2021 16:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232344AbhCLQKa (ORCPT ); Fri, 12 Mar 2021 11:10:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbhCLQKG (ORCPT ); Fri, 12 Mar 2021 11:10:06 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC3DC061574 for ; Fri, 12 Mar 2021 08:10:05 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 124-20020a1c00820000b029010b871409cfso16121918wma.4 for ; Fri, 12 Mar 2021 08:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gefUvqZ+PVzm20AG/CnQcxDANW6owChYqRkVVyHl7s0=; b=Sl0VDnQt+1RMRe2Y4IFrR/8/2P1YiOj0dIPVJzK5P5ql0xp8SVr0TNOeh50qoDz6KD hdOoYBOgsVKy7cVzgXJv1JiPpZEF+nSTBzz7usopk2s6xefngtYEHb384LiWwhxSMbmx e1plY23jcwBWT1DPbVrVB1YLmWjjWw+Cotko0G3lt4jLVscvcoE3VJdNtSFjI4LemH31 gXcI0B6CAuTmoDHKsCa9jUDVvjmWoNMCCoMxJT3XkRnk6fdxWNpcTSQDJa6WFVEObWsn T+I84DxSRkr23E4Q7v35GH+GquSxOd0wMCK8oJXnl6EEQe4bchcIBtvZD2/2G4XD2C9j Q13g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gefUvqZ+PVzm20AG/CnQcxDANW6owChYqRkVVyHl7s0=; b=Oufllqd5LZs8POq7sei33mcT5+vkfOsEXuB3vB4NwRZI6w0PutUfj1fLJ5c5+buiOs hsIY8hg6V3tirre6Cx0LO+sdEyTPfUkCKo8ecCI5sOjH5QYjZm+42MaTlMW9on7xI/lB jo+9fBjFP6MKSfRBbbKyG/BUAMK1+PW7c6VrTXeZiCUA64kOfVq/mg9K8hIWWa3dK3T6 v6yUR4+h5W4V3Oz8joVi7NeTTjsIjSoisetQHEzGK+cjTdgWKA1k/lXkMwx1xOTXB4Nt aWnJpoUaF+gV5x7cCzlo9BpQmCwba+ptIOyw6/ZZtIYxywB1YFiOYjnGWNE8XFqq72/J wrXQ== X-Gm-Message-State: AOAM531ym2NbbhXwAS2x4VhGzKwykC5iX1exbRnsbQEqfxlNRcUBAIdg 2n4SC7pBjx4JCKe5yZUivON3NlMrmcMA6g== X-Google-Smtp-Source: ABdhPJwqnWyb5Onm4bEZd7t3tmBLv63GOvp+mvKlzmJbHrVGsAq6EM3W5O8PyIObMIqloZlcm09D7w== X-Received: by 2002:a7b:c4d1:: with SMTP id g17mr13855852wmk.101.1615565404369; Fri, 12 Mar 2021 08:10:04 -0800 (PST) Received: from agape.jhs ([5.171.80.73]) by smtp.gmail.com with ESMTPSA id s23sm2524163wmc.35.2021.03.12.08.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 08:10:04 -0800 (PST) Date: Fri, 12 Mar 2021 17:10:01 +0100 From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: rtl8723bs: remove unused code blocks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20210312161001.Kz2keOgY0mjNS7pIMYUx0GD9FK0ERGK_J2UgnkFA7Iw@z> remove conditional code blocks checked by unused CONFIG_TCP_CSUM_OFFLOAD_RX cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 5 ----- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 8 -------- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h index b4aeb44d5d6e..078854a55a31 100644 --- a/drivers/staging/rtl8723bs/include/rtw_recv.h +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h @@ -159,11 +159,6 @@ struct rx_pkt_attrib { u8 ack_policy; -/* ifdef CONFIG_TCP_CSUM_OFFLOAD_RX */ - u8 tcpchk_valid; /* 0: invalid, 1: valid */ - u8 ip_chkrpt; /* 0: incorrect, 1: correct */ - u8 tcp_chkrpt; /* 0: incorrect, 1: correct */ -/* endif */ u8 key_index; u8 data_rate; diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c index f52802f24466..78d5b6913467 100644 --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c @@ -138,15 +138,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt pkt->protocol = eth_type_trans(pkt, padapter->pnetdev); pkt->dev = padapter->pnetdev; -#ifdef CONFIG_TCP_CSUM_OFFLOAD_RX - if ((pattrib->tcpchk_valid == 1) && (pattrib->tcp_chkrpt == 1)) - pkt->ip_summed = CHECKSUM_UNNECESSARY; - else - pkt->ip_summed = CHECKSUM_NONE; - -#else /* !CONFIG_TCP_CSUM_OFFLOAD_RX */ pkt->ip_summed = CHECKSUM_NONE; -#endif /* CONFIG_TCP_CSUM_OFFLOAD_RX */ ret = rtw_netif_rx(padapter->pnetdev, pkt); } -- 2.20.1