From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934351AbcKJPmU (ORCPT ); Thu, 10 Nov 2016 10:42:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934254AbcKJPmO (ORCPT ); Thu, 10 Nov 2016 10:42:14 -0500 Subject: Re: [RFC v2 4/8] iommu: Add a list of iommu_reserved_region in iommu_domain To: Joerg Roedel References: <1478258646-3117-1-git-send-email-eric.auger@redhat.com> <1478258646-3117-5-git-send-email-eric.auger@redhat.com> <20161110153724.GG2078@8bytes.org> Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com From: Auger Eric Message-ID: Date: Thu, 10 Nov 2016 16:42:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110153724.GG2078@8bytes.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 10 Nov 2016 15:42:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, Robin, On 10/11/2016 16:37, Joerg Roedel wrote: > On Fri, Nov 04, 2016 at 11:24:02AM +0000, Eric Auger wrote: >> Introduce a new iommu_reserved_region struct. This embodies >> an IOVA reserved region that cannot be used along with the IOMMU >> API. The list is protected by a dedicated mutex. >> >> An iommu domain now owns a list of those. >> >> Signed-off-by: Eric Auger >> >> --- >> --- >> drivers/iommu/iommu.c | 2 ++ >> include/linux/iommu.h | 17 +++++++++++++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 9a2f196..0af07492 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -1061,6 +1061,8 @@ static struct iommu_domain *__iommu_domain_alloc(struct bus_type *bus, >> >> domain->ops = bus->iommu_ops; >> domain->type = type; >> + INIT_LIST_HEAD(&domain->reserved_regions); >> + mutex_init(&domain->resv_mutex); > > These regions are a property of the iommu-group, they are specific to a > device or a group of devices, not to a particular domain where devics > (iommu-groups) can come and go. > > Further I agree with Robin that this is similar to the > get_dm_regions/set_dm_regions approach, which should be changed/extended > for this instead of adding something new. OK I am currently respinning, taking this into account. I will put the reserved region file attribute in the iommu-group sysfs dir. Thanks Eric > > > Joerg > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >