From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Ondrej Zary <linux@zary.sk>, Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Christoph Hellwig <hch@lst.de>, Tim Waugh <tim@cyberelk.net>,
linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] pata_parport: fix pata_parport_devchk
Date: Tue, 3 Oct 2023 20:18:21 +0300 [thread overview]
Message-ID: <a3b4dc62-20f7-4900-b9db-87edc9131063@gmail.com> (raw)
In-Reply-To: <202310031907.45632.linux@zary.sk>
On 10/3/23 8:07 PM, Ondrej Zary wrote:
[...]
>>> There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the
>>> detection to always fail. Fix it.
>>>
>>> Signed-off-by: Ondrej Zary <linux@zary.sk>
>>
>> I think we need a Fixes: tag here...
>>
>>> ---
>>> drivers/ata/pata_parport/pata_parport.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
>>> index 1af64d435d3c..258d189f42e5 100644
>>> --- a/drivers/ata/pata_parport/pata_parport.c
>>> +++ b/drivers/ata/pata_parport/pata_parport.c
>>> @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
>>> pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa);
>>> pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55);
>>>
>>> - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055);
>>> + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55);
>>
>> Oh, Gawd! How did this ever work?! :-/
>> This bug seems to predate the Big PARIDE move...
>
> This code was not present in PARIDE - it's my bug.
Yes, I finally figured -- hence the Fixes: tag I suggested later....
> The function is a clone of ata_devchk() without direct port access.
The libata's taskfile methods suck big time -- I even used to have
the plans to clean this stuff up at some point...
> It's called only from softreset so nobody notices the breakage until something goes wrong. The CD-865 drive needs a reset to start working.
I thought the SRST reset is used at the initial detection phase as well...
MBR, Sergey
next prev parent reply other threads:[~2023-10-03 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 19:15 [PATCH 0/4] pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-09-30 19:15 ` [PATCH 1/4] pata_parport: fix pata_parport_devchk Ondrej Zary
2023-10-02 18:43 ` Sergey Shtylyov
2023-10-02 19:08 ` Sergey Shtylyov
2023-10-03 17:07 ` Ondrej Zary
2023-10-03 17:18 ` Sergei Shtylyov [this message]
2023-09-30 19:15 ` [PATCH 2/4] pata_parport: implement set_devctl Ondrej Zary
2023-10-02 19:52 ` Sergey Shtylyov
2023-09-30 19:15 ` [PATCH 3/4] pata_parport: add custom version of wait_after_reset Ondrej Zary
2023-10-02 20:48 ` Sergey Shtylyov
2023-10-03 17:20 ` Ondrej Zary
2023-10-03 0:55 ` Damien Le Moal
2023-10-03 16:55 ` Sergey Shtylyov
2023-10-03 23:44 ` Damien Le Moal
2023-09-30 19:15 ` [PATCH 4/4] pata_parport-fit3: implement IDE command set registers Ondrej Zary
2023-10-02 20:06 ` Sergey Shtylyov
2023-10-03 17:13 ` Ondrej Zary
2023-10-03 0:56 ` Damien Le Moal
2023-10-03 0:34 ` [PATCH 0/4] pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b4dc62-20f7-4900-b9db-87edc9131063@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=s.shtylyov@omp.ru \
--cc=sudipm.mukherjee@gmail.com \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®