Re: [PATCH] net: dsa: felix: Add NULL check for outer_tagging_rule()

[Andrew Lunn <andrew@lunn.ch>]

On Thu, Feb 13, 2025 at 12:07:54PM +0800, Wentao Liang wrote:
> In felix_update_tag_8021q_rx_rules(), the return value of
> ocelot_vcap_block_find_filter_by_id() is not checked, which could
> lead to a NULL pointer dereference if the filter is not found.
> 
> Add the necessary check and use `continue` to skip the current CPU
> port if the filter is not found, ensuring that all CPU ports are
> processed.

Thanks for reworking the commit message.

You should include a version number in the Subject: line, so we can
keep track of the different versions:

https://docs.kernel.org/process/submitting-patches.html

See the Section about "Subject Line".

Also, you should include a brief history of the patches, what changed
between each version under the --- marker.

There is no need to resend, please just remember these things for you
next patch you submit.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew