From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381BBC83F12 for ; Tue, 29 Aug 2023 09:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230468AbjH2J5S (ORCPT ); Tue, 29 Aug 2023 05:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235090AbjH2J5B (ORCPT ); Tue, 29 Aug 2023 05:57:01 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF63DE4C for ; Tue, 29 Aug 2023 02:56:31 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9936b3d0286so562656966b.0 for ; Tue, 29 Aug 2023 02:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693302972; x=1693907772; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9Jps0qXeyPLdx+b5De4g4xbuY+7aT5vkCHcXrjuUV+Y=; b=hkG7xTYtJQ2ENM4yJoPTcBPNN0RU4igvZPm/ioBwG9SyLNMoZKiCrkg/CqcfrEOS7c /a0Xv1R9MLRvK28utRXeksnBTTDhjskyQMWRTzaaziDgCYFGmdOMsWptrXgInmeTAp7m dB3xN6a9EMLtjCopFh2gVU/uMs8bGMiR+23QKQ68a47UV5Q81E7dd/7TS+xEmTKuhLSl BmtujFHozhifeHO5l3bh4y0gL3YjdfG3yEiayf3rLzypfELB3CtAPB0Mf+LDD1ZmOQpS Jp96InuYxq6Rpsbgsazvf9g+mj28O8FBMvADte0AIPIkPna06rdxNmRfub70QWO0K/5v Ea1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693302972; x=1693907772; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Jps0qXeyPLdx+b5De4g4xbuY+7aT5vkCHcXrjuUV+Y=; b=RGErzgNt/02oiTK09qOFD4v3RTz4XXk7Z/UBv8WKO2AhtfGL1eUkKmFaivBaemFQg/ HtjJMQBc8PW1MJeCaSkF0E0SGkdUh2oCWD3b4+hIpARZKhBf8EefL1Q7XOtNSkVse2UC z+DbiRPubDouY/pCdMgFnjcVkNaHFC2J6PkD/tHK0NMVIZbhtimTvVz+1VxY5KhFeRQx 5y7HAYJ0ythvod58x8jHridH1bO8qhGrX7Kj9mCxF892XXqcZdGWNK40UL/YQNwY1iVr 5djJ8l+KUF+h+uDssIdoiv5KtwYynwvmRebeNWiEKd03WVtaIyFoOXjn2CSaXgpP1YhA 9ZGg== X-Gm-Message-State: AOJu0Yz07dpKpguOffNGXQpv4HkPstvMxcPImWCYhmUPSSuHmA8Mvf4N kZFxWSkHAZE4zDbyvgb4VBadLQ== X-Google-Smtp-Source: AGHT+IEjhxFak4PhQe3Tgs47lEQYmobKxofGOlrRmfYW9HU2F55i2HVmIX6rN/v0yjl1q+ycOMRmMw== X-Received: by 2002:a17:906:2091:b0:9a2:ecd:d962 with SMTP id 17-20020a170906209100b009a20ecdd962mr9825131ejq.4.1693302970981; Tue, 29 Aug 2023 02:56:10 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.196]) by smtp.gmail.com with ESMTPSA id h25-20020a1709063b5900b0099cc3c7ace2sm5878362ejf.140.2023.08.29.02.56.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 02:56:10 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 11:56:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 04/11] thermal: exynos: remove fine-grained clk management Content-Language: en-US To: Mateusz Majewski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Liam Girdwood , Mark Brown , Marek Szyprowski References: <20230829091853.626011-1-m.majewski2@samsung.com> <20230829091853.626011-5-m.majewski2@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230829091853.626011-5-m.majewski2@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/08/2023 11:18, Mateusz Majewski wrote: > This clock only controls the register operations. The gain in power > efficiency is therefore quite dubious, while there is price of added > complexity that is important to get right (as a register operation might > outright hang the CPU if the clock is not enabled). So once it is done right, this stops being argument. The benefit is to keep this clock disabled most of the time, which now we lost. I don't find this patch correct approach. Best regards, Krzysztof