From: Andrew Lunn <andrew@lunn.ch>
To: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] net: phy: aquantia: add get_features() for AQR113C
Date: Wed, 4 Nov 2026 21:57:23 +0100 [thread overview]
Message-ID: <a3bb991a-6935-4ce9-a754-0c4ba9e72662@lunn.ch> (raw)
In-Reply-To: <20261104-net-phy-aqr113c-fix-pma-capability-v6-1-d6d4718e45e3@oss.qualcomm.com>
On Wed, Nov 04, 2026 at 05:59:13PM +0800, Hongmei Xu wrote:
> AQR113C does not correctly report its supported speeds in the PMA
> extended abilities registers. Without a get_features callback,
> phy_probe() uses genphy_c45_pma_read_abilities() directly, which
> produces an incorrect supported mask.
>
> Add aqr113c_get_features() that calls aqr111_get_features() as a base
> (which uses phy_gbit_features as base and forces 2.5G/5G that the PHY
> misreports) and sets 10000baseT_Full explicitly since the PHY also
> misreports 10G.
>
> The AQR113 likely has the same issue since it is a closely related
> variant, but this fix is limited to AQR113C as that is the only
> hardware available for testing.
>
> Fixes: 12cf1b89a668 ("net: phy: Add support for AQR113C EPHY")
>
> Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2026-11-04 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 9:59 Hongmei Xu
2026-11-04 20:57 ` Andrew Lunn [this message]
2026-11-10 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3bb991a-6935-4ce9-a754-0c4ba9e72662@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hongmei.xu@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®