From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbdARQYe (ORCPT ); Wed, 18 Jan 2017 11:24:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:60434 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbdARQYd (ORCPT ); Wed, 18 Jan 2017 11:24:33 -0500 Subject: Re: [RFC 5/4] mm, page_alloc: fix premature OOM due to vma mempolicy update To: Mel Gorman , Ganapatrao Kulkarni References: <20170117221610.22505-1-vbabka@suse.cz> <7c459f26-13a6-a817-e508-b65b903a8378@suse.cz> Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Vlastimil Babka Message-ID: Date: Wed, 18 Jan 2017 17:23:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <7c459f26-13a6-a817-e508-b65b903a8378@suse.cz> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2017 05:20 PM, Vlastimil Babka wrote: > By changing the LTP cpuset01 testcase (will post patch as a reply) this was > confirmed and the problem is also older than the changes in 4.7. -----8<----- diff --git a/testcases/kernel/mem/cpuset/cpuset01.c b/testcases/kernel/mem/cpuset/cpuset01.c index 558420f72f9b..ef673366e15e 100644 --- a/testcases/kernel/mem/cpuset/cpuset01.c +++ b/testcases/kernel/mem/cpuset/cpuset01.c @@ -40,6 +40,7 @@ #include #include #if HAVE_NUMAIF_H +#include #include #endif #include @@ -61,6 +62,7 @@ volatile int end; static int *nodes; static int nnodes; static long ncpus; +static unsigned long nmask[MAXNODES / BITS_PER_LONG] = { 0 }; static void testcpuset(void); static void sighandler(int signo LTP_ATTRIBUTE_UNUSED); @@ -89,7 +91,6 @@ static void testcpuset(void) { int lc; int child, i, status; - unsigned long nmask[MAXNODES / BITS_PER_LONG] = { 0 }; char mems[BUFSIZ], buf[BUFSIZ]; read_cpuset_files(CPATH, "cpus", buf); @@ -105,6 +106,7 @@ static void testcpuset(void) for (i = 0; i < nnodes; i++) { if (nodes[i] >= MAXNODES) continue; + printf("bind to node %d\n", nodes[i]); set_node(nmask, nodes[i]); } if (set_mempolicy(MPOL_BIND, nmask, MAXNODES) == -1) @@ -163,6 +165,8 @@ static int mem_hog(void) tst_resm(TFAIL | TERRNO, "mmap"); break; } + if (mbind(addr, pagesize * 10, MPOL_BIND, nmask, MAXNODES, 0) == -1) + tst_brkm(TBROK | TERRNO, cleanup, "set_mempolicy"); memset(addr, 0xF7, pagesize * 10); munmap(addr, pagesize * 10); }