From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031430AbdADQIb (ORCPT ); Wed, 4 Jan 2017 11:08:31 -0500 Received: from foss.arm.com ([217.140.101.70]:54058 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965501AbdADQIa (ORCPT ); Wed, 4 Jan 2017 11:08:30 -0500 Subject: Re: [PATCH v2] tools: perf: fix linker error when libelf config is disabled To: Jiri Olsa References: <1483537960-14499-1-git-send-email-sudeep.holla@arm.com> <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> <20170104160654.GA11619@krava> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Jiri Olsa From: Sudeep Holla Organization: ARM Message-ID: Date: Wed, 4 Jan 2017 16:08:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104160654.GA11619@krava> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/17 16:06, Jiri Olsa wrote: > On Wed, Jan 04, 2017 at 03:56:03PM +0000, Sudeep Holla wrote: >> When libelf is disabled in the configuration, we get the following >> linker error: >> LINK libperf-jvmti.so >> ld: cannot find -lelf >> Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed >> >> Jiri pointed out that both librt and libelf are not really required. So >> this patch fixes the linker error by getting rid of unwanted libraries >> in the linker stage. >> >> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build") > > hum, AFAICS it linked -lelf and -lrt even before right? ;-) > Yes, sorry I forgot to remove that and trace it back the actual commit. -- Regards, Sudeep