From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D70423E338 for ; Fri, 9 May 2025 21:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746827260; cv=none; b=FnScEn97IF7ccczD5vRV+QxhciQLgDThocRyHMhwmrvGUEPQ/4tc8ac9VnOfYpDe7P5AXxefxhC1RAfc7oli8lYfIhPO23XP+cLpr7eJhqjDJ0CAzQq2lMNJNo0wlHmEHjIna8ofrR/dQpaApTApbbqmqbqiOYQ1qskHpXTPebo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746827260; c=relaxed/simple; bh=LrWZlx3JipRZAEsDNHeSY35/RAjGPR31bHo82ZX/dro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IBF4hpY1HvCucAdxj/G2zI8b4z8T6dYbzwuTBRIeNj90gvDlm8xbGT0IukNIqToT/UXQk3oR448z8S9kzA3hJeLoH3WyfvkuePo4NfBg5twrDu6bBkB9/6RTMbWgyINYDJ0XaLAk0sBLJXm7cAsSu0dQdoOp7b324vGAJlcf7kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RTgmdQUT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RTgmdQUT" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 549C2gC9014025 for ; Fri, 9 May 2025 21:47:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qw/zOKbG+s9dSKA7ogOJ8aB0qk0go7aPu19+W/cL31c=; b=RTgmdQUTW1/TVMbL 8ZUV00SmbEK19CHritlWQxkuwQanDKu/cLuJ6Z3MlC8m+tg+J52fvM5a7Vjom/tD d1RlScq43aoJa9PrH2LomMeIOM3uWAmDgdgjXb7DyBS/uh6vlFA3cl8ISuQQFCen imctM1QaCfRw29k6iDRmdMEUdeNVp3MNe6jBpnBpOlU+jSyJKSflzUmWFe1G0MT3 Ac8gJ5P1HwaFh8PCq227VBwf1alkOTsSTqG7jcvvNIlw2qK6BJFhJcZpE5ONvbyP RWM2p2ZtYqqf/+3KvFSNjiZIyWwx3NiP6K/GeZlGV0Fk9K+LGN8QnvSb4bRhlPim DlidOA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46gnp4nwyr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 09 May 2025 21:47:37 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6f5466289bdso4234206d6.1 for ; Fri, 09 May 2025 14:47:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746827256; x=1747432056; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qw/zOKbG+s9dSKA7ogOJ8aB0qk0go7aPu19+W/cL31c=; b=cG0M5Kmudf4sJNHhmDShsCMTDjWBm/aA/eWsnyzgP3kjv7pMLVGAHTCuiA/oAxf/kJ J0tSAb45BhNPK+KIvYJsJMy8gbH/nONg1zzHs08JUFNOeKyiYFW7ZeTdJDHGtS9n+fSN eFRV2Ho3nHR8ppAGmIaxKt1yMBDDpCGpP2wXR0QLxXfzJhuZilthO10VzIuF8IPnDVwv Oav3KpqILSvNTja085kne/ftkxEnRCxBb5acard/W0QFmnC3HKopJ3VEqkp2v3pL80s8 aBJ3Yyu50hrCu1uFyveYV/+dVxzmYcBtPQM0oz8g5AAG6wf1HzmNqR1tJL1QMSHlGIeD cohg== X-Forwarded-Encrypted: i=1; AJvYcCV3YpSJFdXlwWfFwiWu2s5G9BGAGrDTl7UzYMoPIZfTKVvd4YZ6bFtfE7Bv566iJseAT2qZ2mYqZAD7MGY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz98UDyi+0AQYbJWy3d3uqMr05sGNmyKC8ra64DdWir4qEL9Cdr 1lkVkWD82jjPa4W4PtIEf1brsQ6FG+1aJcxmgqW4hBQElfQ+DwTT1oMCeYC4uej+sb/be9JnYlL /opup1VlZJbreM4r9M72hnp+RGYyKNBzzYkA5Bli1VwTfaBb9zQaT9PteXXtd41c= X-Gm-Gg: ASbGncuVbxpFGxuydkV7j0dth9embX+X93E3BfnJIzEFaxny6O4eIV+ko4s9PoE12ul WQ3Ll54ScJGw61tKE58oPxj5fGFdxvidd1c6DidaP210Ny4KHKX0tA33PSwOmLLFNHaPRR+Ihi2 dPp/L8UIUFOwBHavEtCK59Ks65sF8WpGsOZmYRyLDvSofFSac7Hs5mRzpud1nWTvK8c1VNXCfC4 9+FGl/7vBVzwx0AjOsUwXzNGaDnJhIkGnBhD2hfurp1FvHgvgyi0acHLKZxJU7G2fUZMXbcdwES IWI85cPBmopbPxPQ7+oEABmdxjMtQCH5i6mfRmi7MyL0EeVh6Kvv/w0Ho9vgoBD4vAw= X-Received: by 2002:ad4:5dcf:0:b0:6f4:329d:d3e5 with SMTP id 6a1803df08f44-6f6e480ff24mr28928306d6.10.1746827256393; Fri, 09 May 2025 14:47:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4kVfm3UKCIez6pugUGxDw+qic6FGMUITyhMEPjM/ZFm11+v3bu99CrX3yIWV90/41JaxfmQ== X-Received: by 2002:ad4:5dcf:0:b0:6f4:329d:d3e5 with SMTP id 6a1803df08f44-6f6e480ff24mr28927986d6.10.1746827255955; Fri, 09 May 2025 14:47:35 -0700 (PDT) Received: from [192.168.65.158] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fc9cbe5542sm1910107a12.5.2025.05.09.14.47.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 14:47:35 -0700 (PDT) Message-ID: Date: Fri, 9 May 2025 23:47:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] clk: qcom: ipq5018: keep XO clock always on To: george.moussalem@outlook.com, Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luo Jie , Lee Jones , Konrad Dybcio , Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250506-ipq5018-cmn-pll-v2-0-c0a9fcced114@outlook.com> <20250506-ipq5018-cmn-pll-v2-1-c0a9fcced114@outlook.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250506-ipq5018-cmn-pll-v2-1-c0a9fcced114@outlook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: N9GDpGnieLdSJIwY_razZMvP8CvamtFK X-Authority-Analysis: v=2.4 cv=E5XNpbdl c=1 sm=1 tr=0 ts=681e77f9 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=UqCG9HQmAAAA:8 a=6ibG6wpdE3FgK2yJb9QA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA5MDIyMCBTYWx0ZWRfX55BUtZtV+dL7 UBoMseBGNtXiyHr4zcuPL5xX0l9aK7C8Ig3fFUHv00ZggqERO3LbUtMXapPEw2B1zUgbChFL9ey 7kRSUkUmxm69HpdDQQZ/A03h4YHHQaoy9+rKPk3eOTW2+AStWOB8entpniehLfpj8acyBVng6+j TdMoQFqh0kwT0eO2H3b+V27B7dLmUvisbmE1XPJvXoVwUnqp3w3wG30HFh3kk9U6LEZYgDkCsSu THVtk67ZQT+I1HbW7fCgOQ1SP8VYv8JbmB7Oc4s0hnje9yQOA3ixwTPJID/KV6Ek8kbBMFBy4xa 47iZ7sOcZpNz8wsV2fQvqprZwKIs3EMbzt/ouk50HDNvX+9Nn1UBlUAQXaTqckklkgurEXDUDfX V/MZf4ErPwyr4ga/chuf0ZtW0Kd+L1BUPxn/Ww3IUJkzbM23T4IkIy4Ar/oqHwxDCiTj0CRR X-Proofpoint-ORIG-GUID: N9GDpGnieLdSJIwY_razZMvP8CvamtFK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-09_08,2025-05-09_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 phishscore=0 spamscore=0 priorityscore=1501 mlxlogscore=783 lowpriorityscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505090220 On 5/6/25 7:43 AM, George Moussalem via B4 Relay wrote: > From: George Moussalem > > The XO clock must not be disabled to avoid the kernel trying to disable > the it (when parenting it under the CMN PLL reference clock), else the > kernel will panic and the below message will appear in the kernel logs. > So let's enable the XO and its source CLK and keep them always on. > > [ 0.916515] ------------[ cut here ]------------ > [ 0.918890] gcc_xo_clk_src status stuck at 'on' > [ 0.918944] WARNING: CPU: 0 PID: 8 at drivers/clk/qcom/clk-branch.c:86 clk_branch_wait+0x114/0x124 > [ 0.927926] Modules linked in: > [ 0.936945] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted 6.6.74 #0 > [ 0.939982] Hardware name: Linksys MX2000 (DT) > [ 0.946151] Workqueue: pm pm_runtime_work > [ 0.950489] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 0.954566] pc : clk_branch_wait+0x114/0x124 > [ 0.961335] lr : clk_branch_wait+0x114/0x124 > [ 0.965849] sp : ffffffc08181bb50 > [ 0.970101] x29: ffffffc08181bb50 x28: 0000000000000000 x27: 61c8864680b583eb > [ 0.973317] x26: ffffff801fec2168 x25: ffffff800000abc0 x24: 0000000000000002 > [ 0.980437] x23: ffffffc0809f6fd8 x22: 0000000000000000 x21: ffffffc08044193c > [ 0.985276] loop: module loaded > [ 0.987554] x20: 0000000000000000 x19: ffffffc081749278 x18: 000000000000007c > [ 0.987573] x17: 0000000091706274 x16: 000000001985c4f7 x15: ffffffc0816bbdf0 > [ 0.987587] x14: 0000000000000174 x13: 000000000000007c x12: 00000000ffffffea > [ 0.987601] x11: 00000000ffffefff x10: ffffffc081713df0 x9 : ffffffc0816bbd98 > [ 0.987615] x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 : 0000000000057fa8 > [ 1.026268] x5 : 0000000000000fff x4 : 0000000000000000 x3 : ffffffc08181b950 > [ 1.033385] x2 : ffffffc0816bbd30 x1 : ffffffc0816bbd30 x0 : 0000000000000023 > [ 1.040507] Call trace: > [ 1.047618] clk_branch_wait+0x114/0x124 > [ 1.049875] clk_branch2_disable+0x2c/0x3c > [ 1.054043] clk_core_disable+0x60/0xac > [ 1.057948] clk_core_disable+0x68/0xac > [ 1.061681] clk_disable+0x30/0x4c > [ 1.065499] pm_clk_suspend+0xd4/0xfc > [ 1.068971] pm_generic_runtime_suspend+0x2c/0x44 > [ 1.072705] __rpm_callback+0x40/0x1bc > [ 1.077392] rpm_callback+0x6c/0x78 > [ 1.081038] rpm_suspend+0xf0/0x5c0 > [ 1.084423] pm_runtime_work+0xf0/0xfc > [ 1.087895] process_one_work+0x17c/0x2f8 > [ 1.091716] worker_thread+0x2e8/0x4d4 > [ 1.095795] kthread+0xdc/0xe0 > [ 1.099440] ret_from_fork+0x10/0x20 > [ 1.102480] ---[ end trace 0000000000000000 ]--- > > Signed-off-by: George Moussalem > --- [...] > + /* Keep some clocks always-on */ > + qcom_branch_set_clk_en(regmap, 0x30018); /* GCC_XO_CLK_SRC */ this clock is not a clk_branch2 - its control register is different and this call is incorrect - you can drop it altogether, as if the XO source clock isn't running, the system is dead > + qcom_branch_set_clk_en(regmap, 0x30030); /* GCC_XO_CLK */ This one actually is likely supposed to be always-on too - does removing these two lines do any harm? Konrad