From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02A291E5B96; Wed, 26 Mar 2025 13:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742997440; cv=none; b=Ll9LCJJeebrCjDNAkV/jWdg6ZRI6HbDall8itX/Ym8iZOanaxqNutvWMXO2x45tO+PY/LMjgKpWMgYkE9ZEl56JFEFsToqFMNFqvtcNNWgW8lwfOmDCL3YssZVEiaWELX3ojZ1dicRN/Yx1gH28r3jdAcJjSjIGtcEfutbnb3KU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742997440; c=relaxed/simple; bh=1p8KjiTqjNAHl4UGFhuzwCzlkKafEDA6cKN4ir3X2IQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QbeSFryY9wYuhtGWvHelIjWQhXZvgroMAZG5+mRDldxKqn2tp9qPdlf0oE7sX5hEiCE9UWNI+BEXm2gpp79HCvQpsaVMytfzwJbNcebQHn5/ctrjnDWyq6zE735wNqpeaXIH0kWh0rN4kS7I7BsV6AgoXgoMKHZvFeSHtDXRhXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=kJQt+gNS; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="kJQt+gNS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=PxyiAcHHfe3kkyC2cZnuyzpI8SDABEjryx8RiO625Lc=; b=kJQt+gNSFtCd/oNrhiZZ2hpcOb t4VyIM94+SHLec7RDb2jBJd9rCb0kHKQHRbWB2ohbWP700fgMlR0F/2ExQSGYlHTuYDZ6izm+Ymqm o656XlXUeDxfkL334ZSG3AwTrU/zBw7zI7b+FyQC40GX1i1Az4WskKqbfNzVo1yWck30=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1txRFl-007Ath-Bg; Wed, 26 Mar 2025 14:57:09 +0100 Date: Wed, 26 Mar 2025 14:57:09 +0100 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Christian Marangi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next RFC PATCH v2 2/3] net: phy: Add support for Aeonsemi AS21xxx PHYs Message-ID: References: <20250326002404.25530-1-ansuelsmth@gmail.com> <20250326002404.25530-3-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > In summary, I really don't like this approach - it feels too much of a > hack, _and_ introduces the potential for drivers that makes use of this > to get stuff really very wrong. In my opinion that's not a model that > we should add to the kernel. I agree. > > I'll say again - why can't the PHY firmware be loaded by board firmware. > You've been silent on my feedback on this point. Given that you're > ignoring me... for this patch series... And i still think using the match op is something that should be investigated, alongside the bootloader loading firmware. Andrew