From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D8321257F for ; Sun, 16 Nov 2025 15:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763305748; cv=none; b=pefq4lK9wDxLDp2eZra9x5Q3vLawFW14V7DySW88Y1/gN7yxvW7AYEoJAPcqvrI/zPrn4cKQ1w9W7L1iNenl+b/mo0cHuUP3nzLLoyTa5mB4OQSJAZ5KTqo10CcQi5FDQM43tZSLPn/NY8NiK3CgwNT9DSdZ9souJSTsJDWmxdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763305748; c=relaxed/simple; bh=xq8xTEaVyip20qvmaObDd4dfH1b/XchZRVgFrwvraHE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JKP0e8D8+aj3KXi1ZDLXX9mEnrn3MJw+oSM+o+h5XQd3GPo/eILIqtc15hpEgMagq4GHK0+EdUilvyoqiH3NvfP0ZWlI2eF7m52xxlXGT8DKZkfk3GDR+TlrxzsMMaZqiRkaaO75DrJFvebLqvkEZFUef5uzTDlA6uKltVjG5Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oc6KKPtq; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oc6KKPtq" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47755a7652eso24393465e9.0 for ; Sun, 16 Nov 2025 07:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763305745; x=1763910545; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EvODb/e7qLsRFrmDWJkGdxSLjYJZj6/4elRLF1YEXuE=; b=Oc6KKPtqtYazDKDP0bX02uTJWmEUPOW6uAMkZTKj7Vpbs4AU7lWm09tFd9fgIPys9G itXJh6/j4rVJvnFALAQ2u3TuPdKSaolZeNtkjSwYj5H2xpQKMmjOnfeYC156eyxqRFJi OObe9pXTH1FMSBxhKhK0qZ+DSE+rAo6hlcDPVSBAWJlEvsJI7KkkXpBCM5xSBwR6l/9s MmlxI2DXX9kw0ToFDc1GEksUJDJ8pDOIl+WpaWm5vwyKMeBAqbnw2k8nRF/LuyvKmYR+ pRhSCtin20ITF03WWZaQuPJpWXQBTvWKp4igxWfrT3yC9RCzcRnNcp3xzqoEHxojkU6/ WGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763305745; x=1763910545; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EvODb/e7qLsRFrmDWJkGdxSLjYJZj6/4elRLF1YEXuE=; b=fR6TPGOuxhRO1vxV3w8KxHM26mJjBAh6eR7RadZuyKD+4vfVRyzEgFXtAb+9q2vFSl bFGrCmY42et8qeQlQAZrCtHJsNcCTHPxxhfEG0OBkpZV3iGGNcGpE9b4moAw8usNvkUc NkGxSMSBq9N/eBTTXQqxxt7VmxJeNHG0YlGukEbOKfqlN9CFe1uixl6NXJQFAmeGqtuh ZZAmwR0DfCLrXdzxRSWGgDv2P7DeJyZiMDatkL6D8YDTlA+fwU6IECMctnkF+AtDad9e vKqHg74QuzMckdkikq873JRZbvSgHcxqnfZiQqlEEUOdNA6afMUSJGqqyW3GNz8fi+pr CheA== X-Forwarded-Encrypted: i=1; AJvYcCWt0jmJQBI0X4MUo940e8BPnM0VEbooA+7Uq7E0YHZdZ30IYII8LjxogQjOx90sJ2PSGJp8D/4cTAx3zH4=@vger.kernel.org X-Gm-Message-State: AOJu0YyY7OFyunD5IF9e8ZVrvGkJ8ub5Ix1b+B9GnzBvtBs8iP7ni27y 8/hrmY1ch/nCyDMavlw6LryEZU8wcWoxbONNJgwMsYK0VGorhEKzN5zD X-Gm-Gg: ASbGncsDBjxtZJ9kkdgTJBtHtF+qKUxAk1W15bAQjm26UVGP+wNREW57NBuDsKcO2O0 8zoYxDVBG6twIuSjmpNoxNZzm88xGT7WbHr0q1NvvnAxwMxV+iCdouZPZ6RtXRla3s4QoRwGcS1 fjqJv02E6qG+hyoEfR2vv93S9T5qJckXhKnvluuHsCtuxiIm2eU5Vb9oiInnUaT0re3fipYS0Jt Eht77j1dHuGkH42o+hX7wgvQvbXoSID1wIcrcIKcL96h8QVoUzckgxY25JE68QX1BzXomhwF6qc j51ScAacH39jBUXcT+AtIwCKmpru/gVne0OLPjm6MFldEk1ThlY6IaaNbpoafytFM//lTB9RprV QUdWLOKXsweR3znR2GcCuNbLrM8ESSmdKvs3Q9WLScRWg75DPcq9kAwkSWWCp7zk2T5E+PW3Zvw +sG3s5isbOu6RwvePEK/Te X-Google-Smtp-Source: AGHT+IGMp5GTuzD+R9g6gkfd5sPc9gSs2a2eVt8uvtcAe/vzEoodhAs9XilhHcDZOUcO+nPtbyO15Q== X-Received: by 2002:a05:600c:1d20:b0:477:7a1a:4b79 with SMTP id 5b1f17b1804b1-4778feaaeb3mr87055775e9.37.1763305745160; Sun, 16 Nov 2025 07:09:05 -0800 (PST) Received: from [192.168.1.12] ([197.46.78.60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4779973ddcfsm83154645e9.15.2025.11.16.07.09.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Nov 2025 07:09:04 -0800 (PST) Message-ID: Date: Sun, 16 Nov 2025 17:09:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] HID: memory leak in dualshock4_get_calibration_data To: Max Staudt , roderick.colenbrander@sony.com, jikos@kernel.org, bentiss@kernel.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com References: <20251116022723.29857-1-eslam.medhat1993@gmail.com> Content-Language: en-US From: Eslam Khafagy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/16/25 06:34, Max Staudt wrote: > On 11/16/25 11:27 AM, Eslam Khafagy wrote: >> function dualshock4_get_calibration_data allocates memory to pointer >> buf. however the function may exit prematurely due to transfer_failure >> in this case it does not handle freeing memory. >> >> this patch handles memory deallocation at exit. > > Reviewed-by: Max Staudt > > > One minor thing that I forgot: I see that the commit message is all > lower case. Proper capitalisation helps readability and matches the > kernel style. No need to resend this time, but in case you're sending > a v3 for any other reason, it'd be great if you picked this up as well :) > Oh, ok. but, no plans for v3 for now. > Thanks for your patch! > welcome > Max >