From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257D3C433E9 for ; Tue, 23 Feb 2021 14:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5BC664E6C for ; Tue, 23 Feb 2021 14:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232095AbhBWOxI (ORCPT ); Tue, 23 Feb 2021 09:53:08 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12567 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232908AbhBWOwj (ORCPT ); Tue, 23 Feb 2021 09:52:39 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DlMQX3Hl4zMYLm; Tue, 23 Feb 2021 22:49:40 +0800 (CST) Received: from [10.67.110.218] (10.67.110.218) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Tue, 23 Feb 2021 22:51:30 +0800 Subject: Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup To: Greg KH CC: Lee Jones , , , , , References: <20210222110542.3531596-1-zhengyejian1@huawei.com> <20210222110542.3531596-2-zhengyejian1@huawei.com> <20210222115424.GF376568@dell> <4f06340a-e027-f944-3248-2939639d5e07@huawei.com> <42af110f-f492-c11c-397c-e0b5018d9263@huawei.com> From: "Zhengyejian (Zetta)" Message-ID: Date: Tue, 23 Feb 2021 22:51:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.218] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/23 21:00, Greg KH wrote: > On Mon, Feb 22, 2021 at 09:11:43PM +0800, Zhengyejian (Zetta) wrote: >> >> >> On 2021/2/22 20:36, Greg KH wrote: >>> On Mon, Feb 22, 2021 at 08:20:38PM +0800, Zhengyejian (Zetta) wrote: >>>> >>>> >>>> On 2021/2/22 20:07, Greg KH wrote: >>>>> On Mon, Feb 22, 2021 at 11:54:24AM +0000, Lee Jones wrote: >>>>>> On Mon, 22 Feb 2021, Zheng Yejian wrote: >>>>>> >>>>>>> From: Peter Zijlstra >>>>>>> >>>>>>> commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. >>>>>>> >>>>>>> Both Geert and DaveJ reported that the recent futex commit: >>>>>>> >>>>>>> c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") >>>>>>> >>>>>>> introduced a problem with setting OWNER_DEAD. We set the bit on an >>>>>>> uninitialized variable and then entirely optimize it away as a >>>>>>> dead-store. >>>>>>> >>>>>>> Move the setting of the bit to where it is more useful. >>>>>>> >>>>>>> Reported-by: Geert Uytterhoeven >>>>>>> Reported-by: Dave Jones >>>>>>> Signed-off-by: Peter Zijlstra (Intel) >>>>>>> Cc: Andrew Morton >>>>>>> Cc: Linus Torvalds >>>>>>> Cc: Paul E. McKenney >>>>>>> Cc: Peter Zijlstra >>>>>>> Cc: Thomas Gleixner >>>>>>> Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") >>>>>>> Link: http://lkml.kernel.org/r/20180122103947.GD2228@hirez.programming.kicks-ass.net >>>>>>> Signed-off-by: Ingo Molnar >>>>>>> Signed-off-by: Zheng Yejian >>>>>>> --- >>>>>>> kernel/futex.c | 7 +++---- >>>>>>> 1 file changed, 3 insertions(+), 4 deletions(-) >>>>>> >>>>>> Reviewed-by: Lee Jones >>>>> >>>>> This does not apply to the 4.9.y tree at all right now, are you all sure >>>>> you got the backport correct? >>>>> >>>>> confused, >>>>> >>>>> greg k-h >>>>> . >>>>> >>>> I make the patch basing on 282aeb477a10 ("Linux 4.9.257"). >>>> Should I base on f0cf73f13b39 ("Linux 4.9.258-rc1")? >>> >>> Yes please as I think this is already there. >>> >>> How about just waiting for the next release to come out, I will push out >>> the 4.4 and 4.9 -rc releases right now as well to give everyone a chance >>> to sync up properly. >> Ok, I will rebase this patch then. > > Great, can you try 4.9.258? I'm very glad to. Rebased patch is ready: https://lore.kernel.org/lkml/20210223144151.916675-1-zhengyejian1@huawei.com/ Zheng Yejian