From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbdBWJXv (ORCPT ); Thu, 23 Feb 2017 04:23:51 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2837 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751098AbdBWJXg (ORCPT ); Thu, 23 Feb 2017 04:23:36 -0500 From: Chao Yu Subject: Re: [f2fs-dev] [PATCH 5/5] f2fs: avoid out-of-order execution of atomic writes To: Jaegeuk Kim , , , References: <20170203234816.12723-1-jaegeuk@kernel.org> <20170203234816.12723-5-jaegeuk@kernel.org> Message-ID: Date: Thu, 23 Feb 2017 17:22:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170203234816.12723-5-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.58AEA9E9.0017,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c1fe385da717266834191f01d2a3c738 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/2/4 7:48, Jaegeuk Kim wrote: > We need to flush data writes before flushing last node block writes by using > FUA with PREFLUSH. We don't need to guarantee precedent node writes since if > those are not written, we can't reach to the last node block when scanning > node block chain during roll-forward recovery. > Afterwards f2fs_wait_on_page_writeback guarantees all the IO submission to > disk, which builds a valid node block chain. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu