From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, "Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH] KVM: nVMX: consult PFER_MASK and PFER_MATCH before nested vmexit if inject #PF
Date: Mon, 24 Jul 2017 16:28:03 +0200 [thread overview]
Message-ID: <a3e54db0-eb8d-9316-e8d1-9cf097aef506@redhat.com> (raw)
In-Reply-To: <CANRm+CxYAkt_OoiwQq9rG+bSTHEir_ocEkawUX5Ak3_ibPVdrQ@mail.gmail.com>
On 24/07/2017 15:57, Wanpeng Li wrote:
>
> if (!((vmcs12->exception_bitmap & (1u << nr)) ||
> - (nr == PF_VECTOR && vcpu->arch.exception.nested_apf)))
> + (nr == PF_VECTOR && (vcpu->arch.exception.nested_apf ||
> + nested_vmx_is_page_fault_vmexit(vmcs12,
> vcpu->arch.exception.error_code)))))
> return 0;
No, it would be more like
if (nr == PF_VECTOR
? (vcpu->arch.exception.nested_apf ||
nested_vmx_is_page_fault_vmexit(vmcs12, vcpu->arch.exception.error_code))
: (vmcs12->exception_bitmap & (1u << nr)))
but I've sent an RFC patch that also fixes the exit qualification.
Paolo
prev parent reply other threads:[~2017-07-24 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 1:05 Wanpeng Li
2017-07-24 13:36 ` Paolo Bonzini
2017-07-24 13:57 ` Wanpeng Li
2017-07-24 14:28 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3e54db0-eb8d-9316-e8d1-9cf097aef506@redhat.com \
--to=pbonzini@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®