From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6D8C10F29 for ; Sun, 15 Mar 2020 16:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52187205C9 for ; Sun, 15 Mar 2020 16:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728912AbgCOQJt (ORCPT ); Sun, 15 Mar 2020 12:09:49 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:60843 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728310AbgCOQJs (ORCPT ); Sun, 15 Mar 2020 12:09:48 -0400 Received: from [10.193.177.146] (balakrishna-l.asicdesigners.com [10.193.177.146] (may be forged)) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 02FG9PwS006951; Sun, 15 Mar 2020 09:09:26 -0700 Subject: Re: [PATCH net-next] chcr: remove set but not used variable 'status' To: YueHaibing , ayush.sawal@chelsio.com, vinay.yadav@chelsio.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20200314105120.20968-1-yuehaibing@huawei.com> From: rohit maheshwari Message-ID: Date: Sun, 15 Mar 2020 21:39:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200314105120.20968-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/20 4:21 PM, YueHaibing wrote: > drivers/crypto/chelsio/chcr_ktls.c: In function chcr_ktls_cpl_set_tcb_rpl: > drivers/crypto/chelsio/chcr_ktls.c:662:11: warning: > variable status set but not used [-Wunused-but-set-variable] > > commit 8a30923e1598 ("cxgb4/chcr: Save tx keys and handle HW response") > involved this unused variable, remove it. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/crypto/chelsio/chcr_ktls.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/chelsio/chcr_ktls.c b/drivers/crypto/chelsio/chcr_ktls.c > index f0c3834eda4f..00099e793e63 100644 > --- a/drivers/crypto/chelsio/chcr_ktls.c > +++ b/drivers/crypto/chelsio/chcr_ktls.c > @@ -659,10 +659,9 @@ int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input) > const struct cpl_set_tcb_rpl *p = (void *)input; > struct chcr_ktls_info *tx_info = NULL; > struct tid_info *t; > - u32 tid, status; > + u32 tid; > > tid = GET_TID(p); > - status = p->status; > > t = &adap->tids; > tx_info = lookup_tid(t, tid); Thanks for fixing it. Looks good to me.