From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7647F33A03A for ; Mon, 16 Mar 2026 19:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773688622; cv=none; b=b2CWlAQcJKKfjQrtts5WDL5PLhRm4tuAtg+Zmi/5451i8+S77+vW1UbXKd+9MmifWQDZAsxb3DJBblvYf7jlGeQkwSQjfCTrv4ebBMnBqW2XyjE1Rr7fDuQOL3HEqF1wzNIhA9JMrTQJ1v/WKsfPn5znMKfLBuRrEvnJs9i5VY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773688622; c=relaxed/simple; bh=PlGPZoglXUuh1dfeukJH/LeqqwBMJABO0C248s1v9As=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TwGpY/jadoVy1Q7FSmas+YgEfPrWRXiSr7isQP613l8aP1xS8baioiuX1A/19NUSjKAIyCm8BzNchQ8YkwVJTWG1C1D493e1pysAkUAN9PbVZSj7kRdVn0sspGC8qV/pxXvTuuOFteZSmaooWWv2MWpnAjw4f0PHPITXsR73IxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HD4WVQWy; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HD4WVQWy" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-128e4d0cc48so5658955c88.1 for ; Mon, 16 Mar 2026 12:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773688620; x=1774293420; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=7Hk2XaBHC8Qa6dgUkCoPcN4E9YBKjMdtHqI5bOd6Xjw=; b=HD4WVQWyGgPLd3jJ1GHewURwI2RV136um/ZLg30U6PJAfKIrEqj+6n+G4wRMMjiuBl jOxtr/KhWksLAsVS2bUzx7O6V6pv2zcXY67mVAUKWmNpVsdYM/xTg/D72dHrQYovLI3e Xc8zwrB5H1BzBnHy+qvpqtBiBgv7kMIt97ICOkMTyBnip7Gh6YTYwW9UYg3ibW+J2y9f /HB7uMi6w/jcLl4tLvaMxt2zIkHv/P+3r1jA5hdpi8F2ivOmWTcMm8h/IRIlZF+z3+iq i+e0FdXRJGvD+P5ZsiY4Oe4t1L0iVnud09QWF6I1zhXuuCuhc9u69FUMELRjdH6sZJY3 6nWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773688620; x=1774293420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7Hk2XaBHC8Qa6dgUkCoPcN4E9YBKjMdtHqI5bOd6Xjw=; b=HzJ4IOM6jO9HT5gUjXq7Cz785RnEAezaz0i6PnbeZgRBg4RBSDJS2W4zNsB1jDC7nq Un8mjT7wmExDrG+p/TUdsgxmI7yWDgD5yQka07em7x6K3XpcCO0h5vBX04rj1HKsLw4q jfQgBFz1wEWHEUg0LFINZTaIMPh3dKJk+C22W6SppuqmJMJN7rRchLLMEycVlmFlNouV 4KjrLdk5rnCBlf/5AN2wbyNb/qsA10lQ0hP+fW7VixAKgIoPNPx2UvI9SGj10VrHwPgD viQ2dSuuGjb+pem8pxHHq+YxJVs1vDdWGeG0lbNbgMymoV0kFl+H+RxhomgvFWGXQgn+ kmFA== X-Forwarded-Encrypted: i=1; AJvYcCVEWkKnZHs3r76Dblh6kF8JquxUcUnveIsHsYMjyX0jnv8wynDi4c0Lzl4UvONTaIN9X8qdFrJztzvo5Iw=@vger.kernel.org X-Gm-Message-State: AOJu0YwPboTM9FDWFengsBFMoSVaqBt8DM1QCzy9s9aSttMUB9Yhx28h 3xJIVYryslfZvSTdxhZ3BoPa7A6i/URXzuN6+orIa6T+PPLy2kcdxERX X-Gm-Gg: ATEYQzz6r4IwiIIk0sQNmsoGp8hX/ozXDf8icYm/weoeXTEe6IBqlzk6Ts0Tq+fJXel EkkTTM5EqUy1WgjRBw2KBugJJnwaG9J6Tt0JxR0poyzJMvvMa3wy+5dE2221nPPKOGdNCEo3t8O Q9aCtHdQHL4wQZ/P8LwsdfY5qr6zGy/jvCYWS0A3J/wbz7O0bHZfY9bvu9nxIx1od5rk0tw2FWz eumfEmJ83B8K4wX15QxmwhlRtAK9TyJpqAEeBOJNmxs7og5Y+ws7R4C+eMr76tVOkSm1fQ0ZLo9 z6jK25vx7UCS+nIjmlzl/GJy3qnGYvs73cqBIGSW/7KYr6pSE4uzScNWrRcWJSqK2QshXZrDzV5 +ok8IcjmFFePXhP+rSYu1wU3e1l4U6XmsgAwNeJjqgKc7ppsfOflhTFCgQzcVRyQ+sZhAxHv9D2 vCVQhY1SazAHxucQjI5YbFOryIAohAJEOsUuWs X-Received: by 2002:a05:7022:925:b0:128:bbad:9a52 with SMTP id a92af1059eb24-128f3e52ca3mr5874419c88.39.1773688620362; Mon, 16 Mar 2026 12:17:00 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128f62837ccsm17035721c88.3.2026.03.16.12.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 12:16:59 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 16 Mar 2026 12:16:58 -0700 From: Guenter Roeck To: Kees Cook Cc: Eric Biederman , Justin Stitt , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/2] exec: Add KUnit test for bprm_stack_limits() Message-ID: References: <20240520021337.work.198-kees@kernel.org> <20240520021615.741800-1-keescook@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240520021615.741800-1-keescook@chromium.org> Hi, On Sun, May 19, 2024 at 07:16:11PM -0700, Kees Cook wrote: > Since bprm_stack_limits() operates with very limited side-effects, add > it as the first exec.c KUnit test. Add to Kconfig and adjust MAINTAINERS > file to include it. > > Tested on 64-bit UML: > $ tools/testing/kunit/kunit.py run exec > > Signed-off-by: Kees Cook > --- > Cc: Eric Biederman > Cc: Justin Stitt > Cc: Alexander Viro > Cc: Christian Brauner > Cc: Jan Kara > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > --- ... > +++ b/fs/exec.c ... > + .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) }, > + { { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * + sizeof(void *)), ^^^^^^ Google's experimental AI review agent tagged the above change as syntactically wrong. How does this even compile ? Thanks, Guenter