From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0A038C421 for ; Mon, 18 May 2026 22:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779142684; cv=none; b=Vn64qLYSxFarKZs5x18QkccluOR5FF4N39xTxvPrY80H6uxFrNIMqt83vMPWwurSQEhrWLERAqx4ZSU424R0iPcWijpGf4NcUxHS04vqMS7vyrlurv7bGJlFWVresJzjRpwiwqi+Yc4CmtxPYoKk2gjgYkqmyK1YOM3fRS5Bl00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779142684; c=relaxed/simple; bh=rwy9AaB+YZ2TxWZYUbWBAN5RIBxXVW8FYgve6/rXKyw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Em01NuprRIqyWGbjfmCotkOjEosKpzPt+9dzW6nXlAnU8Fy8mEsizEmoyvE0GYcWo6DuXhocaB1BkCFCbc70mzexXoAF318F9aQSxRtjZ5kYVIKs3r+eY/fIjYqT4TQI2zl70MsBjALjmr9BcznFU+MyzbuUz0fkkUdasrcTRn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p3Q3KQm6; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p3Q3KQm6" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2f03d6cf77bso2906208eec.0 for ; Mon, 18 May 2026 15:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779142681; x=1779747481; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=HvAeM3G6bmkfm6f0wgfGcfgEROVq1lUgw+e1xbuFGjg=; b=p3Q3KQm6XaUwQa2NUL3KVOdeuTe3LAxUmXMs3Y0Xc2kjPHWKWn+Q9dqpXCvc3HaATH XnvbDLJMSOiIsyN3pHPgbU+LBSLhMlK2wGOVh4wGOm4yW1zhOxE7kQAMqCwbfRNHBTvR KMlL0yNOw4KXvCI3bd16RziOhhFcQNfUPWtxaQa+Oj+cgmKEdfJNN8eLJfrZT5lV9QKj VEFWqE6PQn6Ttj4R3HkXD79D34OiuzwWY5rV4vNSP5EQj7X8jslBQtzZiT+yjlmX5nR7 +Z+o04RtoGX6k7v2S7g9B/MKLbYwCAqC2Goy/w/0aw3G9N/5C+yd2iZNmDKQ4Va0z3ve 0BOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779142681; x=1779747481; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HvAeM3G6bmkfm6f0wgfGcfgEROVq1lUgw+e1xbuFGjg=; b=c8LTdcCTODnmD0ISUe0YWbLlnoHxaKzyai/kbLfB9jLcV2Lk7IO5HkwRH6pqZ8GOGh Z61xyJ6kwSMbztwkHF1xlUz88zSDiZ4oo28BEwpoktQqtRYDiEgS+wz/0qX4T1EOcDGm 92s6oQtxmxIWGkDxvllhqAwdfkgVWTdOB+6oDVi38gADBmpnByH0uA0JjeE0mGlOaPoW 7jNJdS40A7JcVh/Dx9yyKr4LufiBysc7KorAXEmVAsIcGgSuX9wFFugaVYTHvGnsCdRH OvsK4sw0ZnvTeFIC30HvNdqe3xzgbZHdxYZbLtZv8W86YHvRAR56bVPwQdYbtsjRFxlu auag== X-Forwarded-Encrypted: i=1; AFNElJ+tASCBz5VQpZn1hQnjqZ3cwj+/p64eQzPMCXsSY9fXbU3WCxEKvs8+jWGWgcY11cjNKvczOPr4Dg40AuU=@vger.kernel.org X-Gm-Message-State: AOJu0YxMCukZEBMQLv8MmBQOiIuUVcIDyvNchCycaAwEQI/f2pRGfMAf 0A9PSTNkQzeZRYH/Bxor8exStYWQXqw9jamxCYURdiop6jzz1OoJT3dO X-Gm-Gg: Acq92OEwxwakAsr8uYl/4FMjBrWapJ2ul4D3rGlj3QoYjk06HCcpOY81sbfhxpvSNh6 RVMcSBVZ58vG2B21VHSrN7RKbwkNG6ZWBx6ZXtZmvUD6VtLlRrYGM3l6tkxc924f02MouadTB3A pUChGWo1UcyWGth8S3Vkm1lDyX9bYStcmueoRrTcEugLGbWJh73ocbwlGZ/5lFWycNytFYOQ+Y9 bJ0ODjr3UTICEXA3kbsIDDWNS2EE+x1Mqngq6ql7vmrxPaNehWqzFKlrF3M2ot3mXUXJHKr7veX aPWVaJs4YJK8esX4eKQjlzbK4C5XZ5KULpzgHdSW9i6w9nYkKRiw7AAdjuEoFVHc7o844SZm6J2 Imq2TR9/a4AUDMjkbAgtFKAOHHyRcr+CmNooCcEHHkbzIAdbrdqlW5UA924x8bEyYw6VuEksIn0 6c9rpDjRj0SbIHba6kO+w+EpEgQ4tbVScahQMg+Pb/NNSOoS8= X-Received: by 2002:a05:7300:fb83:b0:2ed:2942:34ab with SMTP id 5a478bee46e88-3039818afb2mr7606381eec.3.1779142680596; Mon, 18 May 2026 15:18:00 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6c3sm18171998eec.19.2026.05.18.15.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 15:18:00 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 18 May 2026 15:17:59 -0700 From: Guenter Roeck To: Shubham Chakraborty Cc: Florian Fainelli , Jonathan Corbet , Shuah Khan , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] soc: bcm2835: raspberrypi-firmware: Add voltage domain IDs Message-ID: References: <20260516164407.25255-1-chakrabortyshubham66@gmail.com> <20260517080445.103962-1-chakrabortyshubham66@gmail.com> <20260517080445.103962-2-chakrabortyshubham66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517080445.103962-2-chakrabortyshubham66@gmail.com> On Sun, May 17, 2026 at 01:34:43PM +0530, Shubham Chakraborty wrote: > Add Raspberry Pi firmware voltage domain identifiers for the mailbox > property interface. > > Also add the voltage request structure used with > RPI_FIRMWARE_GET_VOLTAGE so firmware clients can share the common API > definition from the firmware header. > > Signed-off-by: Shubham Chakraborty I'll need an Acked-by: from a maintainer to apply this patch, or some other maintainer will have to pick it up. Thanks, Guenter > --- > include/soc/bcm2835/raspberrypi-firmware.h | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h > index e1f87fbfe554..975bef529854 100644 > --- a/include/soc/bcm2835/raspberrypi-firmware.h > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > @@ -156,6 +156,31 @@ enum rpi_firmware_clk_id { > RPI_FIRMWARE_NUM_CLK_ID, > }; > > +enum rpi_firmware_volt_id { > + RPI_FIRMWARE_VOLT_ID_CORE = 1, > + RPI_FIRMWARE_VOLT_ID_SDRAM_C = 2, > + RPI_FIRMWARE_VOLT_ID_SDRAM_P = 3, > + RPI_FIRMWARE_VOLT_ID_SDRAM_I = 4, > + RPI_FIRMWARE_NUM_VOLT_ID, > +}; > + > +/** > + * struct rpi_firmware_get_voltage_request - Firmware request for a voltage > + * @id: ID of the voltage being queried > + * @value: Voltage in microvolts. Set by the firmware. > + * > + * Used by @RPI_FIRMWARE_GET_VOLTAGE. > + */ > +struct rpi_firmware_get_voltage_request { > + __le32 id; > + __le32 value; > +} __packed; > + > +#define RPI_FIRMWARE_GET_VOLTAGE_REQUEST(_id) \ > + { \ > + .id = cpu_to_le32(_id), \ > + } > + > /** > * struct rpi_firmware_clk_rate_request - Firmware Request for a rate > * @id: ID of the clock being queried