From: Quentin Monnet <qmo@kernel.org>
To: socketpair@gmail.com, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Nick Desaulniers <ndesaulniers@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH bpf-next v5 1/3] bpftool: Fix disposal of the LLVM disassembler context
Date: Tue, 3 Nov 2026 22:14:46 +0000 [thread overview]
Message-ID: <a3ef692a-a9b5-4057-b9b6-1279951d7bc1@kernel.org> (raw)
In-Reply-To: <20261103-bpftool-plugin-v5-1-683e08a25df0@gmail.com>
2026-11-03 18:59 UTC+0500 ~ Mark Korenberg via B4 Relay
<devnull+socketpair.gmail.com@kernel.org>
> From: Mark Korenberg <socketpair@gmail.com>
>
> destroy_context() frees the disassembler context with LLVMDisposeMessage(),
> which is a plain free() meant for strings returned by LLVM. The context is
> therefore never destroyed, leaking about 28 KiB per disassembled function.
> Use LLVMDisasmDispose() instead.
>
> Fixes: eb9d1acf634b ("bpftool: Add LLVM as default library for disassembling JIT-ed programs")
> Signed-off-by: Mark Korenberg <socketpair@gmail.com>
Acked-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2026-11-03 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 13:59 [PATCH bpf-next v5 0/3] bpftool: Make the LLVM disassembler an optional runtime dependency Mark Korenberg via B4 Relay
2026-11-03 13:59 ` [PATCH bpf-next v5 1/3] bpftool: Fix disposal of the LLVM disassembler context Mark Korenberg via B4 Relay
2026-11-03 22:14 ` Quentin Monnet [this message]
2026-11-03 13:59 ` [PATCH bpf-next v5 2/3] bpftool: Don't require a disassembler to dump a JITed program to a file Mark Korenberg via B4 Relay
2026-11-03 22:14 ` Quentin Monnet
2026-11-03 13:59 ` [PATCH bpf-next v5 3/3] bpftool: Make the LLVM disassembler an optional runtime dependency Mark Korenberg via B4 Relay
2026-11-03 22:15 ` Quentin Monnet
2026-11-04 0:40 ` [PATCH bpf-next v5 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ef692a-a9b5-4057-b9b6-1279951d7bc1@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sdf@fomichev.me \
--cc=socketpair@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®