From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdAWPXY (ORCPT ); Mon, 23 Jan 2017 10:23:24 -0500 Received: from mout.web.de ([212.227.15.3]:51467 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdAWPXW (ORCPT ); Mon, 23 Jan 2017 10:23:22 -0500 Subject: [PATCH 1/4] perf probe: Delete an unnecessary check in try_to_find_absolute_address() To: Adrian Hunter , Alexander Shishkin , Arnaldo Carvalho de Melo , He Kuang , Ingo Molnar , Jiri Olsa , Masami Hiramatsu , Milian Wolff , Peter Zijlstra , Ravi Bangoria , Wang Nan References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Mon, 23 Jan 2017 16:22:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jLA2ksb5cJdqEC8fUAduTwVfX/9DO+K9ZA2NUYUXgY1nAbkw0ax A9a+XT80rgq9Gt14CU0VY2XEFz//7Zsl3ReKUgE7IA3HmwRuOmS7C60HHORNbUptpKvfa2X X2JNvBfUD2zz42SlZ8G7vF5m84xPIZQo/lXpMPTQGHKPxh52AsQO9YTjZFHZZDzq6Wg4rJ1 c8/cSYEFq2B9Gf9fBTLqw== X-UI-Out-Filterresults: notjunk:1;V01:K0:IJJdyVQyafA=:x7Xl5aMlUzXpwQ/8HrZA2B OkGtQwpPGK4uHNSVAxnJ2V6qF3/GFxQnjxst+qXGy6ElBA64HhYhZAYHWevNtiyYhxS8HmeQM d9AHEIUMZwQKz+jUs4RzX/yJxjTo2y02ZqM+fWDZBfKaF/QZbCi0bpvuIG/F55GcZ8TZmwjLj l6WsqyT9OTQoA7Gg2fJlRU6f8zxcHzbilK6gXgbJfm5wfPKGEDBphKF0nTrgmtiIBR55enxAJ CIgj+VjqfGwNsiNbku30T2JLarq0UEFQAOeyF8VaIggTRoLLoyrvM0plh3ReEYd8TaoL2BRZk sVYrYBAd5hhvrsSIc8G3ubGJ3XP9PeZjZtEwQM14fU3+MG7ospcvRhWt7ycFC/fcbXWaOc1mj YZmZfUgl14KfzVrcftqk3v6joybrSA3ocSih/DEbeGurtdL18u6tuDJuVOtcWB4rIASNIy/24 mPiYQVb817RW7UwSRuANNPuTCDJJTNu+vX8jfgFE/nApsyffRM87a5SxTXaYTiF71aa6nUMQ0 EnGKzBktaUV0DdcqX8R2KH6tS9GiawR+vmVrW914u4movcEwpF4hJPoczK4xSuzeUNwWBY6XO BchPyutpMe8LDfVeCpRH0CqizpcBZowgOySFK002+0F94YlTKkXACy/334+vWfZCVJtldCmgn 3ayXhkU4Q2aVY1d2ezyHvcev3yn57ivzW6lhyOQ2U6JGaR89vsLcx4OJqHDp6mWuz8TJMXFkf 6UXi6sh3EaVYvpPFbK2uk8p3qKMT3QdXpLlpdt6091slui8AyVkxSV2XRsm5y9zWU7iZS/WNQ lEqxAQv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 23 Jan 2017 14:54:26 +0100 Remove a condition check which is unnecessary at the end because this source code place should usually only be reached with a non-zero pointer. Signed-off-by: Markus Elfring --- tools/perf/util/probe-event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index d281ae2b54e8..6c7508337fe8 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -2966,10 +2966,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, return 1; errout: - if (*tevs) { - clear_probe_trace_events(*tevs, 1); - *tevs = NULL; - } + clear_probe_trace_events(*tevs, 1); + *tevs = NULL; return err; } -- 2.11.0