From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C4B021CC40 for ; Thu, 20 Mar 2025 14:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742480711; cv=none; b=p/DsWPstlDFzD7oKWsYijfSRp7pagNlw/wH5iHC23AiWVrUXglwnt+fHmpaUHZ2kKn810yrsikYsHdTG7++Le4W0QZkL3SomBt3M4/XcFYm2znujlrYf1JrUGq23Md3vtCnQsthCErBperxiLglstRclXRb4JAvywjzFpxGUK/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742480711; c=relaxed/simple; bh=F4KnFhSzOX6eIyHkk5hZbAmDvmdul5GOQycv8LDllbU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JL8wrGhc42LgpKJd78210jrG7PjecbWp60XQhBJybUh36UwQVjaGgjjnS7OeYKkuSWU0ALr3oUFMiLO5X96OLl54LT8EasEfvuAvVXbyIUK0rd67vk1N4leZPd1NOVQFOjsypekMLKDz3g8b14yCRAADQOf9WtOKKGHxP5gRcL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=maky9Uhj; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="maky9Uhj" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6e8f916e75fso21016786d6.1 for ; Thu, 20 Mar 2025 07:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1742480708; x=1743085508; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NcufIoTquObc4xvWCnB60+ugCUZsUArli95nP/Pg8FY=; b=maky9Uhje3w22PFPZzsqOOZpe0FBdsqRk8zLWN4jEAWlz/oCpfVEjQ4K9Ym/hP+0qU coKT4dlLGqv0+Es24b02TTuW5Xm8jwLp6Zp+KRPfV/O6Ze7dlN/yqzUJDKENx9OyUEre J8n2UCGBJuI3734QQBfMqWL+00VRxsrU9nGprgw4RbWGTM/YNIT0SMmTaiunQKeIOgDe zAxqclnfdpKqkT15En3Z19FTfhGGq0h6TL3sdfieQnWtiWUJqXPcH6YmKvZ4IjF/hTn0 L3Ay0+huKJXj4g8KgS7N5igke6LMK6jIus297DwDYkEGOxEVizJykWoNr0lLvAzETIm0 dnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742480708; x=1743085508; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NcufIoTquObc4xvWCnB60+ugCUZsUArli95nP/Pg8FY=; b=O4LSa55eqAbQu5liz3Cwvlosp8oY0LbMWNgDNV9Kq3lhT+8RKK/GYHItfz39OiNumE jqPqZ96MVAOyywIHvcVsDjwJtXp0JEtn2eOvLF/IHr5YDn/EjuMT3LH9bKt8e4ypYU9W UTC6/mpIdbzP1sVYVgtn79pMcOLwCZhwP+pwfxRV5Kf0/9PBmY02SWLZ5Izw3pDYDXHT U0wjiCEP5v4BZiW0fPQUMq8Bj+SaR+J4EEhv5joUEITrLkXJQNI5a8qpQy9+YQXRYxZL EGrX6hK9UE+Fpr/QxkUE5YKmT4pHhKSKrVwjUAfWcFdG9gStZNVDTPUPHKbW9ddqQg6c yjYw== X-Forwarded-Encrypted: i=1; AJvYcCWeEP6ZhmuRl1x4d3EQjWGZYHOsR/VAkVXrCi8UjJ1/V+O5cHUcGEk0hhCCNnZGV1HCGtdUtwRaa6AiEUU=@vger.kernel.org X-Gm-Message-State: AOJu0YxwP/gc9fBgm9kUmHQ5lUsDtG55iV5Cx3C/lQksDTR8a3Tmzia0 9K61cR8Zksaenrmd2pWv3bfhPDx5EpUKHWTGUEjyVUauPVfKMxd281F0x2BGdQ== X-Gm-Gg: ASbGncvG9jt1uFR6ZEQlUCaOa3NmnTApFTWtG3UPGk1NOwsmUi2NE77qCt7BIRVN7vD qJ5pMOqnDu9ipUwPz833FZTtVvtXyMY4cN0+Hcs6rNXrbg6np2O9sSPZPke5HxyqRj0kv49+zFQ CIJXg7mQW1OYL+PftZSkOJuienbEGse6WS+EP64NX2q9lQIe0X4wvkLaJH/yg+wQKVqYwITRO9Q iBPkNve6VKPLKUGJHNLrYppA4fCqpkZU8BRDyV1F+9CkRjFY5RuFmmHP8H8rd0GlSX2UDDpEU6J HoVx6zQXg/AxcZvIS5xD5o2SK+GpKGq809qWFbHO7QEfX7nw2x4N1bVTR94rp+mnnfay0X8mk6D eKp47hGxT4mjBJcTMKHrpcWnzE8uW4bEqH+anug== X-Google-Smtp-Source: AGHT+IHfUR49FUmIocj39iu24611PkyzTcnBbnp3e5L3vO6SSH1McNWe6SG8aTCWtlijcQKBijjCLA== X-Received: by 2002:a05:6214:1d2f:b0:6e4:2e5b:8d3f with SMTP id 6a1803df08f44-6eb349d1a0bmr59972906d6.14.1742480708068; Thu, 20 Mar 2025 07:25:08 -0700 (PDT) Received: from rowland.harvard.edu (nat-65-112-8-24.harvard-secure.wrls.harvard.edu. [65.112.8.24]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eade209beesm94796156d6.10.2025.03.20.07.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 07:25:07 -0700 (PDT) Date: Thu, 20 Mar 2025 10:25:05 -0400 From: Alan Stern To: Oliver Neukum Cc: =?utf-8?B?55m954OB5YaJ?= , Greg Kroah-Hartman , Dmitry Torokhov , Kun Hu , Jiaji Qin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, syzkaller@googlegroups.com Subject: Re: WARNING in cm109_urb_irq_callback/usb_submit_urb Message-ID: References: <559eddf1.5c68.195b1d950ef.Coremail.baishuoran@hrbeu.edu.cn> <62d91b68-2137-4a3a-a78a-c765402edd35@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <62d91b68-2137-4a3a-a78a-c765402edd35@suse.com> On Thu, Mar 20, 2025 at 02:35:23PM +0100, Oliver Neukum wrote: > > > On 20.03.25 05:39, 白烁冉 wrote: > > Dear Maintainers, > > > > When using our customized Syzkaller to fuzz the latest Linux kernel, the following crash (94th)was triggered. > > > > Hi, > > is there a way to use the syzkaller for testing a patch? > > Regards > Oliver > From 03d78ca8c47c8c888df7c7ae2c7109825799d236 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum > Date: Thu, 20 Mar 2025 14:29:17 +0100 > Subject: [PATCH] USB: cm109: fix race between restarting and close > > cm109_input_close() can race with cm109_restore_state() > Hence cm109_submit_buzz_toggle() needs to check > the shutdown flag > > Signed-off-by: Oliver Neukum > --- > drivers/input/misc/cm109.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/misc/cm109.c b/drivers/input/misc/cm109.c > index 0cfe5d4a573c..8ae62b5e45f6 100644 > --- a/drivers/input/misc/cm109.c > +++ b/drivers/input/misc/cm109.c > @@ -348,6 +348,8 @@ static void cm109_submit_buzz_toggle(struct cm109_dev *dev) > else > dev->ctl_data->byte[HID_OR0] &= ~BUZZER_ON; > > + if (dev->shutdown) > + return; This test must itself be subject to the same race, right? There needs to be some kind of synchronization between the two tasks (i.e., a mutex, spinlock, or something similar). Alan Stern > error = usb_submit_urb(dev->urb_ctl, GFP_ATOMIC); > if (error) > dev_err(&dev->intf->dev, > -- > 2.48.1