From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
admiyo@os.amperecomputing.com
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v5 1/3] mctp pcc: Check before sending MCTP PCC response ACK
Date: Fri, 13 Sep 2024 17:21:06 -0400 [thread overview]
Message-ID: <a3f91c94-e829-4942-abde-193462769cba@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20240801124126.00007a57@Huawei.com>
>>+ * @shmem_base_addr: the virtual memory address of the shared buffer
>If you are only going to map this from this pointer for the
>initiator/responder shared memory region, maybe it would benefit
>from a more specific name?
I am not certain what would be more correct.
On 8/1/24 07:41, Jonathan Cameron wrote:
>> + pchan->shmem_base_addr = devm_ioremap(chan->mbox->dev,
>> + pchan->chan.shmem_base_addr,
>> + pchan->chan.shmem_size);
> devm doesn't seem appropriate here given we have manual management
> of other resources, so the ordering will be different in remove
> vs probe.
>
> So I'd handle release of this manually in mbox_free_channel()
How fixed are you on this? mbox_free_channel is the parent code, and
knows nothing about this resource. It does no specific resource cleanup.
The only place we could release it is in the pcc_mbox_free, but that is
essentially a call to the parent function.
All other comments should be addressed in the next version.
next prev parent reply other threads:[~2024-09-13 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 2:36 [PATCH v5 0/3] MCTP over PCC admiyo
2024-07-12 2:36 ` [PATCH v5 1/3] mctp pcc: Check before sending MCTP PCC response ACK admiyo
2024-08-01 11:41 ` Jonathan Cameron
2024-09-13 21:21 ` Adam Young [this message]
2024-09-16 9:51 ` Jonathan Cameron
2024-07-12 2:36 ` [PATCH v5 2/3] mctp pcc: Allow PCC Data Type in MCTP resource admiyo
2024-08-01 11:43 ` Jonathan Cameron
2024-07-12 2:36 ` [PATCH v5 3/3] mctp pcc: Implement MCTP over PCC Transport admiyo
2024-07-13 7:31 ` kernel test robot
2024-07-13 7:53 ` kernel test robot
2024-08-01 12:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3f91c94-e829-4942-abde-193462769cba@amperemail.onmicrosoft.com \
--to=admiyo@amperemail.onmicrosoft.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jassisinghbrar@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®