From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbeAWBnf (ORCPT ); Mon, 22 Jan 2018 20:43:35 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:34296 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbeAWBne (ORCPT ); Mon, 22 Jan 2018 20:43:34 -0500 Subject: Re: [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure To: Keith Busch , Christoph Hellwig Cc: sagi@grimberg.me, james.smart@broadcom.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, axboe@fb.com, maxg@mellanox.com References: <1516607585-1525-1-git-send-email-jianchao.w.wang@oracle.com> <20180122201423.GA30427@lst.de> <20180122215436.GS12043@localhost.localdomain> From: "jianchao.wang" Message-ID: Date: Tue, 23 Jan 2018 09:43:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180122215436.GS12043@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8782 signatures=668655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=958 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801230018 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph and Keith Really sorry for this. On 01/23/2018 05:54 AM, Keith Busch wrote: > On Mon, Jan 22, 2018 at 09:14:23PM +0100, Christoph Hellwig wrote: >>> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_1_19_68&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=7WdAxUBeiTUTCy8v-7zXyr4qk7sx26ATvfo6QSTvZyQ&m=xJVh7u7o8UBQko2JJRmxqldiuMhaIosNJN8WTkhAF98&s=uk1TvCGpW928A4GMJh1tvxNvPiVfgJvFjjPn69f8fNA&e= >>> Suggested-by: Keith Busch >>> Signed-off-by: Keith Busch >>> Signed-off-by: Jianchao Wang >> >> Why does this have a signoff from Keith? > The the nvme_sync_queues is from Keith in the mail thread, so I added this. I will discard it and just reserve "suggested-by" later. > Right, I hadn't signed off that. I just trying to get feeback if > someting like that was closing the theoretical gap, which it does. Yes. > > I actually have something similar in my patch queue I was about to send > around this area, though. I don't like having the IO path take on the > error handling, and I think ending unstarted requests directly will be > better long term. Yes. Many thanks for your kindly response. Thanks Jianchao