From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: "Clément Péron" <peron.clem@gmail.com>,
"Colin Didier" <colin.didier@devialet.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Clément Peron" <clement.peron@devialet.com>
Subject: Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT
Date: Thu, 31 May 2018 11:33:43 +0300 [thread overview]
Message-ID: <a4042956-24e1-6132-4606-b5b8f4e30023@mentor.com> (raw)
In-Reply-To: <20180530120327.27681-6-peron.clem@gmail.com>
On 05/30/2018 03:03 PM, Clément Péron wrote:
> From: Colin Didier <colin.didier@devialet.com>
>
> Add missing compatible and clock properties for EPIT node.
>
> Signed-off-by: Colin Didier <colin.didier@devialet.com>
> Signed-off-by: Clément Peron <clement.peron@devialet.com>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index c003e62bf290..0feec516847a 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -844,13 +844,23 @@
> };
>
> epit1: epit@20d0000 { /* EPIT1 */
epit1: timer@20d0000 { ...
And /* EPIT1 */ comment can be removed, it is quite clear from the same
line context.
Formally it is a subject to another patch, but I think this can be
accepted as a part of this one.
> + compatible = "fsl,imx6q-epit", "fsl,imx31-epit";
> reg = <0x020d0000 0x4000>;
> interrupts = <0 56 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6QDL_CLK_IPG_PER>,
> + <&clks IMX6QDL_CLK_EPIT1>;
> + clock-names = "ipg", "per";
> + status = "disabled";
> };
>
> epit2: epit@20d4000 { /* EPIT2 */
Same as above.
> + compatible = "fsl,imx6q-epit", "fsl,imx31-epit";
> reg = <0x020d4000 0x4000>;
> interrupts = <0 57 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6QDL_CLK_IPG_PER>,
> + <&clks IMX6QDL_CLK_EPIT2>;
> + clock-names = "ipg", "per";
> + status = "disabled";
> };
>
> src: src@20d8000 {
>
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2018-05-31 8:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 12:03 [PATCH v4 0/5] Reintroduce i.MX EPIT Timer Clément Péron
2018-05-30 12:03 ` [PATCH v4 1/5] ARM: imx: remove inexistant EPIT timer init Clément Péron
2018-05-30 12:03 ` [PATCH v4 2/5] clk: imx6: add EPIT clock support Clément Péron
2018-05-31 3:07 ` Rob Herring
2018-05-30 12:03 ` [PATCH v4 3/5] Documentation: DT: add i.MX EPIT timer binding Clément Péron
2018-05-31 3:10 ` Rob Herring
2018-05-31 8:26 ` Vladimir Zapolskiy
2018-05-30 12:03 ` [PATCH v4 4/5] clocksource: add driver for i.MX EPIT timer Clément Péron
2018-05-31 8:36 ` Vladimir Zapolskiy
2018-06-04 9:21 ` Clément Péron
2018-05-30 12:03 ` [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT Clément Péron
2018-05-31 8:33 ` Vladimir Zapolskiy [this message]
2018-05-31 8:41 ` Clément Péron
2018-05-31 8:54 ` Vladimir Zapolskiy
2018-06-04 9:10 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4042956-24e1-6132-4606-b5b8f4e30023@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=clement.peron@devialet.com \
--cc=colin.didier@devialet.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®