From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AA9383998 for ; Thu, 25 Jun 2026 09:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782379855; cv=none; b=TcKPGQUtS4mv3TYiiSr21eyqBsasNZUsI5bOXV1/+cXbr7ZkIiNxbVgmdTRCuDFbDSVj11OJlw2cmI1w7StdeyoBaY+uGlaRRjRD+VuCFkm/jI+nm6X8xwY3a2YRx4u3ATBnxqs8yogoSEZSmYRebzO70pOpUOGQpQ00jIPB0Z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782379855; c=relaxed/simple; bh=Ti2vyQS/TU5C7wIgQY3ivFIxKmWrKEzhF5JB+whcpls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f6qI0EUMWneuC42S0S9FH7k2+QbOdvB7F0J2IacisJHIGOvcSqZe6CrdL8ARdKetV+eot5SavMC5pyHmV9TRg47hbQbRnuCP6cAGZV5NFb/2nQZ53PS1PZzKu4+qwU1x6P4iFzvldoYQIclc76Ykqm8n8TKQJAWMXyB3MU/0ZdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NOXp3fKt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jGdezW1H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NOXp3fKt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jGdezW1H" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P8pcvH1346038 for ; Thu, 25 Jun 2026 09:30:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9kiNU5eCrBUsFdtzJac4egp5/e+quc8h+dzXJz3unbU=; b=NOXp3fKtefJwbSdd yHYqPtuwEHf3CCcnxnnbqQmEVagIiBVZMLB5WpZykx51jYJg1ceemLXFOyTob2Y/ 0cRXoCQshJRvJYTnPcASBMs0Ug5LbqGe4f1M6HAC54zNfVUA/d9A8HQnnSX7PK0t 7HQbkGnvsy0vILul1aTvqGxi7TOZdEzKDIS/8vXFASdNAYevX3YYGUgZxUqyxvfI D8WDTR4ljYE9Zglu8DdawiyMuX53BMk+ACAkt5DD7cb1TvYS3nkzoUS/xF6wGbzJ Wl94fo52XyULlju2r0KzFlyky1zyBWFG4LoXwySTDSUR6dIHJg58ApOUZJsb0ZPr SEZgmw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0nv7jnje-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 09:30:53 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-517796be724so4059321cf.3 for ; Thu, 25 Jun 2026 02:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782379852; x=1782984652; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9kiNU5eCrBUsFdtzJac4egp5/e+quc8h+dzXJz3unbU=; b=jGdezW1HHPrZRvroJJlQZR+jiYpeeVWHBf08/jboWGAP55KxnfUtqPhRPwiB2CLisT EZQMFgFRvEgsAE3pfPBore+6/0WeYRcjiwvurXtVQBsEgnA20fhaZLfmUm02Itc+gZxY JqwdpYlfB7sPw/SxP0VldvaPTSKawnjmhO55I/6xGeE7YOU3mOWp4rnzTGhdzwCkEaFa 4ORn4s4Xo4MjmjddEHl9VM9iEQwofOQ+wC5DaaZJY98j/Y3kRTlWGk4bdNU/IgFf8UqM fPw/6NR5fUkTJ6f3EZ5Kq8ZTQ2fuzDhzYjaaKk1W1/visUB9oan77fskNmWvxaiK6x5a U3HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782379852; x=1782984652; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9kiNU5eCrBUsFdtzJac4egp5/e+quc8h+dzXJz3unbU=; b=Op6fbnqv1tq0CzcykvgT8NqKbl6O8EzowXwP0FV8rGP9D3cLHQBj0DvrO777tRxAVw LB6PUnAB1StAf45QPMeB517G306mTXdUaWqY25b/fttZWH4iqgXRpLVwk+mYkn20kZ+u oQ7lAMvyRpTabHeyYS339DZf7OhN6fdOFlWbT2qRxRyPOBl+/yQlWl2YvsrHlMDn59C+ PBTbAVZSi5sHkzy0LQzfwOo8eI/WWyu+jyqo05v/cEmmcPoWxpt0kRUku7+IPntVpVTP +tKzOkRnNSVFj1hvg3V6GnoafSwdHcunUZ0zSPtkHde4a2mPUfZoaFA9k4sroHgLThAh z0CA== X-Forwarded-Encrypted: i=1; AFNElJ+e/X+kVEQdYjrvYTSnyiKV32Odgc5tJsPH8W5xyUFxQxVNnuui9SCYup4blOCSGO8fBGE+nLSDk25LaiE=@vger.kernel.org X-Gm-Message-State: AOJu0Yytn8jJwOAf1aHKA/atbXpIoFV1wZXpT1wLhTMyHhkH0eE61sIh 1Ovvq/I6cswDmuWRBHR0AVJ73Fca2uqiTwnVvZTJ+xnSveEBmDfa6A33RptDZY5KkKMUnWysrDj 0QH+butGJJnAIU1irlaEH969IDU+6iERT61WuoXsx5O3UJ8Ps2NmjAFhdj2HE+dLbzgk= X-Gm-Gg: AfdE7cnHVBnU4iVkAoUagxx3rgOrZfN+yywTxPE6YsdoUeYmRjbpYW9yRVQF8XucI8B bb7qPet4PjZodiZ5Itt1MSHMoyPzkPscc0Qk/zS4vXRlyKEE6839/e2DS7OcoSoDV1ponrR2eoB KpUFhCjj7UF1oOOeLg/lrd1vt5nEUAyn5HlvUwwpKZUm9kJqoeS+V8eJD0392NDKGw9bPoDZ5jJ DkDUqCFcc2gwhtjJERZTQyPs85YhvkVA0iAoY7a2W58l/UkkSE9Uj6wWZ17n8oLkO8+GNXVQCLW V+5f+bQ2B9pjlHtt5tm3QYFpv41NxFS6yw2D7mLyUHcRwpH5lWKbZ+n21orKWZ9sOQI/vM+6P1X eMJTJSRaiMpxabgWF6wTwoCFr+KMNJEVrAuo= X-Received: by 2002:ac8:57c5:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-51a72a47ba5mr12397641cf.3.1782379852405; Thu, 25 Jun 2026 02:30:52 -0700 (PDT) X-Received: by 2002:ac8:57c5:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-51a72a47ba5mr12397371cf.3.1782379851814; Thu, 25 Jun 2026 02:30:51 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c120dcc55besm26167866b.44.2026.06.25.02.30.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 02:30:50 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 11:30:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rubikpi3: Enable cameras To: Hongyang Zhao , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rosh@debian.org References: <20260616-rubikpi-next-20260615-v1-1-3d96b89397ff@thundersoft.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260616-rubikpi-next-20260615-v1-1-3d96b89397ff@thundersoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDA4MCBTYWx0ZWRfX89FWuHKe6sBl uXpaGjTSr3hDQ4kDWxG4rVm9Rpl1TtEepSPuVJ419ap8J2bYiO+B5Itg7Omdo8CoSzjeEjqJtpo MHFieLd1MYulq0IjSwUCox0xOvC5SKQ= X-Authority-Analysis: v=2.4 cv=RJiD2Yi+ c=1 sm=1 tr=0 ts=6a3cf54d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=Wdb1h0LgAAAA:8 a=_exkqQx61WUZkfqn73kA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=j5gyrzqu0rbr1vhfHjzO:22 X-Proofpoint-ORIG-GUID: Lue1a5zpyDwfBpLjTI7FfjEzlublnWMH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDA4MCBTYWx0ZWRfXwttY3zYskjE3 J56UAgGR4XGodfkcASiy0OQk0O2WXAfYsnQmDiQDrsIVNFZ2Ud865dcW4KiBzhgNZxtVbiX05gK AF6N8nZMCuHYmAE8GLE6IU2Z5VlhhrJu6e3ck17GP+7uE5YlzjDUirmrojoB5ZqimtEnO7+9Irt KHJobF0wxkTg3qs4GBX7tKjs4jysqPEcu4U9fzY+aJgFoZbljxRg0leQifUvxylcWhRshYYohl8 pLFhFun5VehZ4E2/VomRDtUUWzmg8JR+Yj/hOqco81aYdJMVEH+CG/JQIWB13qzkU7TRb7n0lXA 9RbFWYPiXjW42uP0zbfxhUOIzp5kD4kFsTTgK7fDP8ymY+3TfliPlN3TkLAapvJldN/KCZmPNYQ D3dn5BJjZLFjm6YXUxgAWjh9e7S0kalBx1X6T5o0wCoeYY7xBpGrAI3TpuY7VpusicDQRtQ3hRE p6hiIgV5WzKO3RfvLhg== X-Proofpoint-GUID: Lue1a5zpyDwfBpLjTI7FfjEzlublnWMH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250080 On 6/16/26 9:29 AM, Hongyang Zhao wrote: > Enable the two Raspberry Pi camera connectors on RubikPi 3 with > IMX219 sensors. CAM1 is connected to CCI1 and CSIPHY1, while CAM2 > is connected to CCI0 and CSIPHY4. > > Add the shared 24 MHz camera oscillator, camera power enable > regulators, CAMSS endpoints, CCI sensor nodes and privacy LED GPIOs. > > Signed-off-by: Hongyang Zhao > --- [...] > + vreg_cam1_pwr: regulator-camera1-pwr { > + compatible = "regulator-fixed"; > + > + regulator-name = "vreg_camera1_pwr"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 57 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&cam1_pwr_en>; > + pinctrl-names = "default"; > + > + vin-supply = <&vreg_vcc3v3_output>; > + }; > + > + vreg_cam2_pwr: regulator-camera2-pwr { > + compatible = "regulator-fixed"; > + > + regulator-name = "vreg_camera2_pwr"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 58 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&cam2_pwr_en>; > + pinctrl-names = "default"; > + > + vin-supply = <&vreg_vcc3v3_output>; > + }; Are these supplies part of the baseboard? [...] > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* CAM1 is routed to CSI1 / CSIPHY1. */ I believe these comments are self-explanatory given the names of the labels [...] > + cam1_privacy_led_state: cam1-privacy-led-state { > + pins = "gpio18"; > + function = "gpio"; > + drive-strength = <8>; > + output-low; Please drop the output-foo properties from TLMM pins, the GPIO state will be controlled by the driver Konrad