From: Michal Simek <michal.simek@amd.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>, Rob Herring <robh@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: arasan: Add ZynqMP props
Date: Fri, 25 Sep 2026 14:58:41 +0200 [thread overview]
Message-ID: <a40e0664-f6bf-4e08-9649-2f8676b6c1ba@amd.com> (raw)
In-Reply-To: <87wls9jxw7.fsf@bootlin.com>
On 9/25/26 14:52, Miquel Raynal wrote:
> On 25/09/2026 at 07:20:03 -05, Rob Herring <robh@kernel.org> wrote:
>
>> On Fri, Sep 25, 2026 at 11:16:21AM +0200, Miquel Raynal wrote:
>>> Hi Rob,
>>>
>>>> + num-cs:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>> + minimum: 1
>>>> + maximum: 2
>>>
>>> I am not sure I get what is the purpose of this property. It looks like
>>> a downstream property resurfacing. We expect one DT subnode per chip, so
>>> I don't see the need for num-cs, we just need to count the children
>>> nodes. For me, the correct fix is to drop num-cs from the upstream DT.
>>> The only real use for it would be if the hardware could be synthesized
>>> differently, with a single CS instead of 2, but I don't think it's the
>>> case here.
>>
>> Indeed.
>>
>>>> +
>>>> + power-domains:
>>>> + maxItems: 1
>>>
>>> This one, even though we don't actively use it in Linux, it may serve a
>>> real purpose.
>>
>> The driver core takes care of 'power-domains', so how is it not used?
>
> Yes, it is probably useful. I am pretty sure I did not use that property
> when I tested the driver, but the controller was either already set up
> by the Bootloader or in a domain enabled by another device. In both
> cases, it is worth adding.
It shouldn't be a problem to list it. We have never used it but obviously there
is power domain.
Thanks,
Michal
prev parent reply other threads:[~2026-09-25 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 18:31 Rob Herring (Arm)
2026-09-25 9:16 ` Miquel Raynal
2026-09-25 12:20 ` Rob Herring
2026-09-25 12:52 ` Miquel Raynal
2026-09-25 12:58 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a40e0664-f6bf-4e08-9649-2f8676b6c1ba@amd.com \
--to=michal.simek@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®