From: Markus Elfring <Markus.Elfring@web.de>
To: Chen Ni <nichen@iscas.ac.cn>,
dmaengine@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: pl330: Handle the return value of pl330_resume
Date: Wed, 17 Jul 2024 13:45:24 +0200 [thread overview]
Message-ID: <a41053b4-b42d-4aca-a8dd-c9f4c901e5dc@web.de> (raw)
In-Reply-To: <20240717072706.1821584-1-nichen@iscas.ac.cn>
> As pm_runtime_force_resume() can return error numbers, it should be
> better to check the return value and deal with the exception.
Please improve such a change description with an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94
How do you think about to use a summary phrase like “Return value from
a pm_runtime_force_resume() call in pl330_resume()”?
Regards,
Markus
prev parent reply other threads:[~2024-07-17 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 7:27 Chen Ni
2024-07-17 11:30 ` Ulf Hansson
2024-07-17 12:08 ` Markus Elfring
2024-07-17 11:45 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a41053b4-b42d-4aca-a8dd-c9f4c901e5dc@web.de \
--to=markus.elfring@web.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®