From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A721CAA92 for ; Fri, 24 Jul 2026 13:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784900633; cv=none; b=KyV71+c0prJuUZInbdWIeja9aWbePMyk+tTAE4MiGLOBZfvRMp8rvSOXn6yMi/8WiOo1imuhg7NgS0CgaKE8W9COEIW7dyV9tgAAcN1B//CL9qMFxTNf+D3aQ3Flj0/IIsODmUiZkjSBufIsRs9N/ZZKMRuAvf71A6IK+qpa4gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784900633; c=relaxed/simple; bh=7rKr8+DrxOVUTRG754FKdDz4YxLx99k2TRqYvtiwVck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E6tqcycKiwyWqRwYxLghkhZKOmzmDJb/2ZvKgZ0JdcNTddrGGWb9+k5z2J7nH+opSb5uvcYhPK7uraJpT205X9KC5LO4lmHUJ2lkXKSkAViZZ4+z2vN8vnlt/zLFSy8JiX5hN5QMILnYRteV48GbAnyxDBUf975MOvdAZQ59Vio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u07MjkkN; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u07MjkkN" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5aeb7ccb9f0so50134e87.0 for ; Fri, 24 Jul 2026 06:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784900629; x=1785505429; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=idJUlieRLjgB9AQfn+Reki5FvFaXB/Lvpwq2VVswqrE=; b=u07MjkkN87EhvYmuOgzXJMISa4xKubWD/mZqUaZFOhf4XuAjz5koJIBxTn5jjmFUI5 daEKRRtH3KC50zeSA3WjYV5VyVj06+pFWSzzSVYxyhnWE+hxXCB74Jkvm1LypLhwc7Lo 1U1v1kqip8Zcjsx8D61UgZBpsXHHldRpruPZa/DViZAhYZE30YUGIlG6G6UcCVRJRcn1 8X3pk8FoMh+EldcR1GBmoeGul1M47Zz2hI9vGyxaJzQVPgn3wuz3K7SWrGpKuWWYnetv FmUApdcqL/MIcW129T5Xw5/ROCvK3ToLcPl0wgmt+aM+OspUMzmsYo/aW75wDW55QiW4 xgqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784900629; x=1785505429; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=idJUlieRLjgB9AQfn+Reki5FvFaXB/Lvpwq2VVswqrE=; b=Dl5OLqTSbjudiNeYuCMgPZe+Du9d977X76hfBYFqtfshm5eY3J7X65r/ycoVAdbErO +Zv700641MT9RPv7a6pI25SMKtWcVNLb1Fs4j4KGf4U+ILGz3c1k3Z1tMdjBZr3r0/rV X+eXXcMnDnEUE4B4YbBZu67YGq94475uxe3eNHe2ovCW65OTI1R/rP5A5XOtpmLX4hc7 NVQakIwvtwhmWtOeSe8Exs8t1NDTQVbaZH6JipfNaLJSzNtCOvra5+zn38+lccDQM9Wj KwTs1YUGEa5LppRavfTYuAwdtHoZEaV/9YfOho2txB+4XIq8Yr2KxaMBAeFpm8x8/29f Ldhg== X-Forwarded-Encrypted: i=1; AHgh+Rr2KVjDuRAofgHI9JcVj5hr33v3x/+ak4JqYboYAwalIDaEqWdYN0tat2Je/zj8Yhuj/dm5sEAEBPQqjyU=@vger.kernel.org X-Gm-Message-State: AOJu0YxfiZ+dG+N23tj4+Df+ao7VCbzDhVF8Ea89ZaZEZecTeIOOKH5T NCwrrwRyRmLiAnAL2tAY+q74NEd5jVTIdz9CYZsCA0MAn8dWfP7n2Hzdnv4oY8OSgH8= X-Gm-Gg: AR+sD12Wj4YEoAyvAjwWteFlpYpAS8U0hNnNVOu/UgQ6rY9dw7BlskXLZiYAD9kYxnK cBgcHJI0TxfRfBRMVVHFg1bf8e3BgIvJIkOgNhsLHOfyrGSri9iOodi3SSaJWx1W6lw3RJzBKjc 0i365Q3Wgsm1jsGBVuAH1bQXsaVymQzuKpvlBsJQ2fG5SOXJ6X6PSy5rZ48Ka1f0lKUWaSoq1ks rNLtf1P3Egqc4NtwaHJdqqovhU2TC8gdILnzuetKt97nFWj7Zx7ci5fY4NQbOkAkQyZsK3Ajfop PusVVo/m7DFgP7boD4tGUKeGXTVx8+07H+GHb64EXJmSDimSJefvn+zRlHZdKFvyMVZym1RMmQC QJo8SBsrZOrt0QSHQupfVeLw+phdqqSXtjsKdJ+JzicEUVJ7F/qQhnOJ4d+/0Ty4HA2sP4cFUqR WYerV7/VxpTM10i+Gf1zv3r0vR7fhzePtQ3RzRHjZAUXGuEvlLcEqe7O0j X-Received: by 2002:a05:6512:1256:b0:5b0:6aea:cdb5 with SMTP id 2adb3069b0e04-5b2b7ad323amr500833e87.1.1784900629495; Fri, 24 Jul 2026 06:43:49 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9b9b68fsm1503254e87.24.2026.07.24.06.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 06:43:48 -0700 (PDT) Message-ID: Date: Fri, 24 Jul 2026 16:43:48 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/17] media: i2c: os05b10: Add test pattern options To: Tarang Raval , sakari.ailus@linux.intel.com, mehdi.djait@linux.intel.com Cc: Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718200912.16001-1-tarang.raval@siliconsignals.io> <20260718200912.16001-8-tarang.raval@siliconsignals.io> From: Vladimir Zapolskiy In-Reply-To: <20260718200912.16001-8-tarang.raval@siliconsignals.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/26 23:08, Tarang Raval wrote: > Add V4L2_CID_TEST_PATTERN support with multiple sensor test-pattern modes > and program them via register 0x5080. Drop the fixed 0x5080 setting from > the common register sequence so the pattern is selected only through the > control. > > Removing the default write of 0x04 to register 0x5080 does not change the > sensor's default behaviour. The value 0x04 leaves the test pattern enable > bit (bit 7) cleared, so the sensor remains in normal streaming mode. It > only programs the color bar style field, which is ignored unless a test > pattern is enabled. > > Signed-off-by: Tarang Raval > --- > drivers/media/i2c/os05b10.c | 55 +++++++++++++++++++++++++++++++++++-- > 1 file changed, 53 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c > index 61c51844a91e..4e177eacc815 100644 > --- a/drivers/media/i2c/os05b10.c > +++ b/drivers/media/i2c/os05b10.c > @@ -102,6 +102,17 @@ > > #define OS05B10_REG_FORMAT2 CCI_REG8(0x3821) > > +#define OS05B10_REG_PRE_ISP_20_0 CCI_REG8(0x5080) > +#define OS05B10_DISABLED 0x00 > +#define OS05B10_COLOR_BAR_1 0x80 > +#define OS05B10_COLOR_BAR_2 0x84 > +#define OS05B10_COLOR_BAR_3 0x88 > +#define OS05B10_COLOR_BAR_4 0x8c > +#define OS05B10_COLOR_SQUARE 0x82 > +#define OS05B10_BW_SQUARE 0x92 > +#define OS05B10_TRANSPARENT_EFFECT 0xa0 > +#define OS05B10_ROLLING_BAR_EFFECT 0xc0 I'd rather split the values into 0x80 "enabled" mask and a specific mode value, but this is also good as it is. Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir