From: Eugen Hristev <ehristev@kernel.org>
To: Balakrishnan Sambath <balakrishnan.s@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 03/10] media: microchip-isc: synchronize the IRQ before disabling clocks on stop
Date: Fri, 19 Jun 2026 11:01:34 +0300 [thread overview]
Message-ID: <a4116337-64d8-4a10-8c1d-c14abc1ce6aa@kernel.org> (raw)
In-Reply-To: <20260616-balki-isc-prefix-fixes-v1-v1-3-b23677fc5ab6@microchip.com>
On 6/16/26 14:50, Balakrishnan Sambath wrote:
> isc_stop_streaming() masks the DMA interrupt and then drops the runtime
> PM reference, which disables the ISC clocks. microchip_isc_interrupt()
> may still be executing on another CPU at that point; it reads ISC_INTSR
> over regmap, and touching the unclocked registers triggers an external
> abort.
>
> Store the IRQ number at probe and call synchronize_irq() after masking
> the interrupt, before dropping the PM reference.
>
> Fixes: 91b4e487b0c6 ("media: microchip: add ISC driver as Microchip ISC")
> Cc: stable@vger.kernel.org
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
Reviewed-by: Eugen Hristev <ehristev@kernel.org>
next prev parent reply other threads:[~2026-06-19 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 11:50 [PATCH 00/10] media: microchip-isc: AWB, stream-stop and endpoint-ref fixes Balakrishnan Sambath
2026-06-16 11:50 ` [PATCH 01/10] media: microchip-isc: fix awb_mutex and lock lifecycle Balakrishnan Sambath
2026-06-16 11:50 ` [PATCH 02/10] media: microchip-isc: take a reference on the parsed endpoints Balakrishnan Sambath
2026-06-16 11:50 ` [PATCH 03/10] media: microchip-isc: synchronize the IRQ before disabling clocks on stop Balakrishnan Sambath
2026-06-19 8:01 ` Eugen Hristev [this message]
2026-06-16 11:50 ` [PATCH 04/10] media: microchip-isc: disable histogram and flush AWB work " Balakrishnan Sambath
2026-06-21 6:23 ` Eugen Hristev
2026-06-22 11:27 ` Balakrishnan.S
2026-06-16 11:51 ` [PATCH 05/10] media: microchip-isc: clean up histogram on the start_streaming error path Balakrishnan Sambath
2026-06-16 11:51 ` [PATCH 06/10] media: microchip-isc: do not touch WB registers when not streaming Balakrishnan Sambath
2026-06-16 11:51 ` [PATCH 07/10] media: microchip-isc: fix pfe_cfg0_bps comment Balakrishnan Sambath
2026-06-21 6:27 ` Eugen Hristev
2026-06-22 11:32 ` Balakrishnan.S
2026-06-23 6:29 ` Eugen Hristev
2026-06-16 11:51 ` [PATCH 08/10] media: microchip-isc: fix PM runtime leak in AWB work handler Balakrishnan Sambath
2026-06-16 11:51 ` [PATCH 09/10] media: microchip-isc: fix SBGGR10 Bayer pattern Balakrishnan Sambath
2026-06-16 11:51 ` [PATCH 10/10] media: microchip-isc: fix WB offset and gain register field masking Balakrishnan Sambath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4116337-64d8-4a10-8c1d-c14abc1ce6aa@kernel.org \
--to=ehristev@kernel.org \
--cc=balakrishnan.s@microchip.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®