From: Helge Deller <deller@gmx.de>
To: Colin Ian King <colin.i.king@gmail.com>,
Bernie Thompson <bernie@plugable.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: remove redundant initialization to variable identical
Date: Sun, 25 Sep 2022 13:12:19 +0200 [thread overview]
Message-ID: <a4146b46-4936-80c9-8839-45bbe2c39cb6@gmx.de> (raw)
In-Reply-To: <20220907135056.679617-1-colin.i.king@gmail.com>
On 9/7/22 15:50, Colin Ian King wrote:
> The variable identical is being initialized with a value that is never
> read. The variable is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan-build warning:
> drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical'
> during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/udlfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
> index c863244ef12c..216d49c9d47e 100644
> --- a/drivers/video/fbdev/udlfb.c
> +++ b/drivers/video/fbdev/udlfb.c
> @@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes)
> const unsigned long *back = (const unsigned long *) bback;
> const unsigned long *front = (const unsigned long *) *bfront;
> const int width = *width_bytes / sizeof(unsigned long);
> - int identical = width;
> + int identical;
> int start = width;
> int end = width;
>
prev parent reply other threads:[~2022-09-25 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:50 Colin Ian King
2022-09-25 11:12 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4146b46-4936-80c9-8839-45bbe2c39cb6@gmx.de \
--to=deller@gmx.de \
--cc=bernie@plugable.com \
--cc=colin.i.king@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®