From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D273E51E8 for ; Mon, 6 Jul 2026 23:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783379292; cv=none; b=btwV3t4qt8p8WEORQsoL1zx3YealQOFalaGsUZtO4KbuD48lA0rJVYrTd94Oklm+OTDr+JLOPAbQ0kAEzE/2+P4FLecVx2oG6VPr/7wUWXkZ9vktfQjbwcRZupywsWlXpW+KcSfIn/DsnslfuyhZApqLZqHreI4N0CTrODIyjt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783379292; c=relaxed/simple; bh=fP4cb5raVdV0BNrKT6hgR1cR0oDSSdWWTlJiXbMB01E=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hZeTSTfSgy+1S/Q6l4AVO83iUTA6hmhMvQPIqAAHpcVPg2ODMeqFPsbG0igNbRKoiVpAA+15CRCcDZZE0AEDUg0LglUEbXdj3vXjfcx9Qh3KU0SyAsE5dLy94swWyW9dxoHVByVLa0HTBGc9qKEsaCypaDSeTJFoWGTUFN7ozW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GTBlyeNe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GTBlyeNe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F05DA1F000E9; Mon, 6 Jul 2026 23:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783379291; bh=aCSGbrbNCmRHD5dpcY6vkC/h6zD+OY0qdy1Ne5XpiHY=; h=Date:Subject:To:References:From:In-Reply-To; b=GTBlyeNeCSHzkkoXWuAfvLtXK5Kc04vsDKpzvnemKKe/8dME3Cf+7K1kBs1Zurtn+ Ca8h9IvpXemWHzowfZakxrXjXuOdp8n35+MQx4m3u0bYqErkV9iJsTaH8ke8seJKeh H8464bEngpEWpDbhPX6PpsJN0VJ2i2qmbZ4DLLLy9Z2/fpPWw31Y/UMO5BN0xYKXRv LNTg1pzkgwHBW4h5JSaPrlVzMp5UASv07tOyxcuJcsHofNamyV5KGrI1o2L3x9Qh8+ 4iG08Hsptg2vNwv/cY9RZbFA62omZ1h2H05hMvcG/01QyNVSJyNsjg5vTlP4DhXgsY lqyYZ1/O3sNgg== Message-ID: Date: Mon, 6 Jul 2026 18:08:09 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] firmware: stratix10-svc: fix memory leaks and list corruption bugs To: tze.yee.ng@altera.com, Richard Gong , Greg Kroah-Hartman , Alan Tull , linux-kernel@vger.kernel.org References: <7f1bfc5d40ec63b41cf85efdc702ecf53c99a5c9.1782295465.git.tze.yee.ng@altera.com> Content-Language: en-US From: Dinh Nguyen In-Reply-To: <7f1bfc5d40ec63b41cf85efdc702ecf53c99a5c9.1782295465.git.tze.yee.ng@altera.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/24/26 05:06, tze.yee.ng@altera.com wrote: > From: Tze Yee Ng > > Fix a memory leak when gen_pool_alloc() fails by freeing pmem on the error > path. Switch pmem allocation from devm_kzalloc() to kzalloc() with > explicit kfree() in the free path to match its list-managed lifetime. > Remove the erroneous list_del(&svc_data_mem) which corrupted the list head > on failed lookups. > > Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") > Cc: stable@vger.kernel.org # 5.0+ > Signed-off-by: Tze Yee Ng > --- > Changes in v3: > - Remove blank line before Signed-off-by. > - No code changes. > > Changes in v2: > - Remove if (!chan || !kaddr) early return from stratix10_svc_free_memory() > per review; failed lookup is handled by dropping list_del(&svc_data_mem). > - Add Cc: stable@vger.kernel.org # 5.0+. > - Minor commit message cleanup (lifetime spelling, subject line). > --- > drivers/firmware/stratix10-svc.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c > index 00e134e663c8..ccf57dfd9a2d 100644 > --- a/drivers/firmware/stratix10-svc.c > +++ b/drivers/firmware/stratix10-svc.c Applied! Thanks, Dinh