From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FC6913B29B for ; Mon, 4 Nov 2024 14:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730729486; cv=none; b=ufF+lxnfmhLu9hsd//ovQ2XigYwTZ+2kQ3Ol5Uf9MbaOenYMXRRRQ1L2KRc8L4QJ7iwypCRTqJk6dV+0TeumSi/ITymZi1KDwZSxXRLa5pElXRmiW2zlBd8auYsxvvvqP37yw8O+v54Q0IQp+o8c7EADxI+IE5zG/PIoGK9cf30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730729486; c=relaxed/simple; bh=Mb1NAHwy4i/OehlNAj/7mKmxIJiSPMovAsyefDQqPCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pygY8cBbGxr8H6xB/JZdN3XJHP1zVqRivKwFGXmCtc0I0Z3v59BB/u76jK+zBwv5PMAREcu2ViNaONgQJkq83jbSPsyYhKBNw+xU9Dq2ZE0Ml0pfKj9cFvKzR5ut2zCFgXKnFhMUuspWEi23vFx3ZFXZQrZHqgle29wDWz4GfiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X5DayAdE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X5DayAdE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A4BUCks008885 for ; Mon, 4 Nov 2024 14:11:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OWQGK+gFqiAdlvvCufCcwMSL0mH6zzKf4LLgUnrZec4=; b=X5DayAdEp6wWCsxl 4YtvZQekepElalg4PMAXyJkPQOyArVsqiA4e5mpGb2vQoVxMGIkUSteUhmWvhDa5 yLUNgLAIEvjLKxUw4Q+7XUpk78mbA1pnKSK4aVUHTPfy4rLZYA2S9vxuTm+RWaiW YJqRHwOPC9Y1FayC5yXGyP47tlgEKQLsUYfCMXdlEO/mBx0po+WODsWIMcR/Jb4v t6EtKFrX8rTIe1qyNBrMIgYwgImC5NiNLgoky6h6r6KITLwTH/K8KhAXvxXTN4HC Bh59JQN+rl2Y3PPGgk1PzXaQrc2Au+us40Ez7Mc6Ihc/fdSVtM4liQtfx1C0Mbfs LnFb0w== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42nd11vf7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 04 Nov 2024 14:11:24 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-71806530394so400250a34.2 for ; Mon, 04 Nov 2024 06:11:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730729470; x=1731334270; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OWQGK+gFqiAdlvvCufCcwMSL0mH6zzKf4LLgUnrZec4=; b=ZfyFcwUkzf6aQvTMeTICj0Y7bvt4ON2LmvP+xfTRiEparr/Oi7heF1zvPvU3cFq9Wz IJhB+MGM4TSb807T9Wwo5+XA+CednR20Vo6Q8Z8q43z/YjrnAB9YmBm2CtPK4+72ZvTC h9AzEX2smOy9f9L4+vX7BF8ZuY9sCIYlxUWaj5gNCCpuT/4mGjMdvdXgHJhODiY2SMUU cLpaq1xOtlMBgLboz+j/t9c8vRX5s2Z0umEbDk4hjsTbNeiIfHaPa2cKfYQObcMIddp4 VJXBvees+PFZpQrg2u/Of1pmM1Ln46DIZlxGEsPaEOzkzHTwrQ3Cmk7e/pHa+OMURi2l qSsA== X-Forwarded-Encrypted: i=1; AJvYcCVr0S6mwrlXEWMwq+QAxRzIsl3tptDpLBQSz0WfkhAwshQmnZmErbxmhRU+3CXCs5QRhj5FWq8TwJXZO3Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6zcRPPdGR/D8RgLKYzTGklTr4GlweiH5/eHHFztjQY6C+FQty S6Oe7DSqTpI00d2X8y25RiF3F/neju0aTX5S+RZ2bTwnh/inBfkMGSrdO8Joiz1yB17x1Zdmhmp uu2jUwzibTXqeFpN10hkCZvVx4QbrsQqyGLLIpTgIeWrg5IRIri04bPKmqM08iZc= X-Received: by 2002:a05:6808:13c7:b0:3e5:f6b0:6ece with SMTP id 5614622812f47-3e6384c54e0mr8553313b6e.8.1730729470509; Mon, 04 Nov 2024 06:11:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeLnK3SNwDSbU/S8+Adq+C7BNiBcubtYMDM1I7j21B1MpWE1qSEckxqqAiiqRZlKmn1s3qYA== X-Received: by 2002:a05:6808:13c7:b0:3e5:f6b0:6ece with SMTP id 5614622812f47-3e6384c54e0mr8553301b6e.8.1730729470101; Mon, 04 Nov 2024 06:11:10 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e56645da9sm556198566b.164.2024.11.04.06.11.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2024 06:11:08 -0800 (PST) Message-ID: Date: Mon, 4 Nov 2024 15:11:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: Add coresight nodes for QCS615 To: Jie Gan , Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tingwei Zhang , Jinlong Mao , Tao Zhang References: <20241017030005.893203-1-quic_jiegan@quicinc.com> <69be09ec-e9a5-4fb6-890e-74a65f3ce404@oss.qualcomm.com> <3f90b3d6-9637-47b7-ad8a-ff43cb28ad32@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: svtJho7VQJ48j2c98_U4cvph5ImM9tmc X-Proofpoint-ORIG-GUID: svtJho7VQJ48j2c98_U4cvph5ImM9tmc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411040124 On 28.10.2024 3:53 AM, Jie Gan wrote: > > > On 10/28/2024 8:54 AM, Jie Gan wrote: >> >> >> On 10/26/2024 2:47 AM, Konrad Dybcio wrote: >>> On 17.10.2024 5:00 AM, Jie Gan wrote: >>>> Add following coresight components on QCS615, EUD, TMC/ETF, TPDM, dynamic >>>> Funnel, TPDA, Replicator and ETM. >>>> >>>> Signed-off-by: Jie Gan >>>> --- >>>> Already checked by command:dtbs_check W=1. >>>> >>>> Dependencies: >>>> 1. Depends on qcs615 base dtsi change: >>>> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615- v3-5-e37617e91c62@quicinc.com/ >>>> 2. Depends on qcs615 AOSS_QMP change: >>>> https://lore.kernel.org/linux-arm-msm/20241017025313.2028120-4- quic_chunkaid@quicinc.com/ >>>> --- >>>>   arch/arm64/boot/dts/qcom/qcs615.dtsi | 1632 ++++++++++++++++++++++++++ >>>>   1 file changed, 1632 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/ dts/qcom/qcs615.dtsi >>>> index 856b40e20cf3..87cca5de018e 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>>> @@ -202,6 +202,18 @@ l3_0: l3-cache { >>>>           }; >>>>       }; >>>> +    dummy_eud: dummy_sink { >>> >>> Node names (after the ':' and before the '{' signs) can't contain >>> underscores, use '-' instead. >> Sure, will fix it. >> >>> >>> [...] >>> >>>> +        stm@6002000 { >>>> +            compatible = "arm,coresight-stm", "arm,primecell"; >>>> +            reg = <0x0 0x6002000 0x0 0x1000>, >>> >>> Please pad the non-zero address part to 8 hex digits with leading >>> zeroes, across the board >> Will fix it. >> >>> >>> This looks like a lot of nodes, all enabled by default. Will this run >>> on a production-fused device? >> Yes, usually Coresight nodes are enabled by default. Those nodes can run on the commercial devices. > Sorry, my last clarification is not clearly. The Coresight nodes are enabled by default for commercial devices(fused), but only part of functions can run with commercial devices because it needs check fuse data before running. > > If we want enable all debug functions related to coresight nodes on commercial devices, we need APDP override(APPS debug policy override) procedure first. The APDP override procedure will override some fuse data to allow debug sessions. In other words, will a production fused device boot with this patch applied? Konrad