From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C21632E125 for ; Wed, 29 Oct 2025 09:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761730915; cv=none; b=c80hOTfWbMUcVHT5JK64K3+ulFrtl2J+8VIAreO+9RtyjEWB579RLZ9bjRtt2PknwfJWnVhHSXA+jQSWj6MkNyMIjDOxngUFQTgtz9o4CcUwz8xILbW4sd+jm/BhVG3A+dXFOgfHYLf+EKnb1d50/oWjVzT+JzcIoU2UdIbhVDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761730915; c=relaxed/simple; bh=ZOi5+PRldexpSha7keeTtkH0mo4OUbEhwxCztfxGWKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SkTq+0mGoyU+KW6sb07aGo/JUX/90If1zm+skjUliwHC0ZZVLcgv9sTn4aV8DZzFOPgHiadKb9Bqp5utYl122qje31fuvOeheyIaNWEUAdWgfPXkCI72pKpcTjqHCpMwdLgKeIAZ5KHPoyRgqoX+tA5f3axgPNNukgupFTeNvDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T4aFPGi+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hbSelOga; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T4aFPGi+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hbSelOga" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59T4v6tk3755067 for ; Wed, 29 Oct 2025 09:41:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QqjyF8y2mKsBJXQTQYPPr2zee4Q5OaRzaCjvfgZqcXM=; b=T4aFPGi+rg6S0BUi k6aIQdp7INIz/pj+TNof9mXgULrS1+krgjimZ9BADkHntmwICuFb7+MKbF7Cel/8 GSqE/8RmTGJFh2Fkjnzrjhje4y+4xx1IKUrxIjxseWhCuxjq15jzN/EbeBxHlVQ7 jwIzLBuutb09lR+i3OeMfpsn6J5gH+2mnyxzT38i0av0TNSPI8jyfW/+tLAjmAAj MGhANOt8XhwWZL1Zdsi1XTD4twYYYkA9e7BzLUBAqiiso8dUEAsz07TNqLAN8tve iz7jfCWP3kjtJX56PAo83ITNQ2RjsfbUAjfUPNNzR7QmbaFECDc2D983ioj6CLG5 5t5feA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a34a021vs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Oct 2025 09:41:52 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-883618130f5so300337485a.1 for ; Wed, 29 Oct 2025 02:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761730911; x=1762335711; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QqjyF8y2mKsBJXQTQYPPr2zee4Q5OaRzaCjvfgZqcXM=; b=hbSelOgabU7HzfJrFG3Vf55Q7oxlryl4FfWBngG4gIzLEA2gtf+Ik8JgDLx3h8A7mv pm4d3cLwxVwsuanjSyiCdQTkJ44VLIMB8fNbLE7KVMbQsIHWfwgTnukfCR9y4toeBgwn Y4RE0YWTdX1Y/dD2G+74ijR3l8Zaftodu199u7wOfCc2yrALxAAqLm84fdRlFfuH+cRF 9w23MYU4wU3n+HnFQC6YbJ/fhZ8MKSc8puG1QWQTQM1c7OI6AKLN7TgILFtbrxVYnWGX U1r6IV94lXpA0+OoqS5ktk0amiM8X6tg4OG5kbgqjSS34rymR0tt55byjt+ugowqnALE RuYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761730911; x=1762335711; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QqjyF8y2mKsBJXQTQYPPr2zee4Q5OaRzaCjvfgZqcXM=; b=C1jGSE2pAX3C39AWFmFyBzvMqXPZ9r52loKREvrIMiz/vpn+HrEWtjEd0jLeCTcUjP G8FwVP28LxZyO0aE70pnoTWGkcN4NyJ/p/uIup9zANnikvix9LV5+3YCWsYAQz+deo2E t/cFre0Zy2pHWuKRpMK9JHI5/BaQnTJqFFlYuYXe2nrP2bM1qvKQT0s1XJcEgL44f0br E2ekuFQEiNkDaxUWQm/usD+blpvwSZ/XTEJA84O2U0eLMKpMmes6SQB/GW9cf4Asytqp EgoVcPQcA+QztcrPNDhfn7CfZTuiXmFh1hctHoUjEq+RqgdMFelLDQiPBa49AtaZqRQb L1vQ== X-Forwarded-Encrypted: i=1; AJvYcCUUGjwNkx9R9ky1ycHj7KstmZ62SGnpXnlHvRyrzm8SrF7FRUc+yDGSXrX5StMkLWurkmAJ7fVO6YKbOwc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1FH6xepR7NG4yyKkFOJqfyg/PkbIjACk8XndrxLEK+l0L9o6q 3+YXNjv0MEhIh8a0v7CrnT3axe7TleSBNmt6lZWfL5e1qvWiVRuD6Rv7owDvnqENmqdOGVIeS3Q Fn18gwRT6ZyMxykFh/3DhuqAbpjieJ0ojd8fQuD/HE0qKpSg60aapm6jIJQ/w8BrXZpo= X-Gm-Gg: ASbGncvdKsVsEXQOLeSX13vRQjgcNDg0DmDDP0oPQFgo5ICCcaWt0WfYB8iy0wTPznV 7+wAoMOi/5iJgN+1LqIXr6KxnP/VxmBe40kEsInJ+uXILjlduro5e++2hYHol2YcYUYxWFnm77A sgpWkvPLg8VcRjweqCfiDO+XqvkN2rDaYAKDsAYaoiKslFtH/rN3YKrYbVyZQJQ2dIuU1Fs5kQH GJxM/ovSK+5VXxN9keBNywRtKqQOxIXPozxlEEKAvS0WUXtPeI22+fNRkPoyLmBWYqGf2f6x8L3 uZ6IrhlhkCbdlCJpuKlzI4BoNZ5Anwmd+nYMg/r00sErkpGJv/cb4MoEq/Y4anSz2+GvXWVONdd ie9XIpWDCaVGiiUEe8wQwer8orhl/BCThp995UA1k6W551tNtE10Cm6XA X-Received: by 2002:a05:622a:48:b0:4eb:a0f9:628e with SMTP id d75a77b69052e-4ed15c05fddmr18502371cf.8.1761730911161; Wed, 29 Oct 2025 02:41:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEirvGmsZylTV9U2HOR76rZ/Vmr4UWRyqd+KI4uycauBNB1qqXAgzUpmQy9dJI5ECemHbmBVQ== X-Received: by 2002:a05:622a:48:b0:4eb:a0f9:628e with SMTP id d75a77b69052e-4ed15c05fddmr18502181cf.8.1761730910742; Wed, 29 Oct 2025 02:41:50 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d85369675sm1376051666b.28.2025.10.29.02.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Oct 2025 02:41:50 -0700 (PDT) Message-ID: Date: Wed, 29 Oct 2025 10:41:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] crypto: qce: fix version check To: Jingyi Wang , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Thara Gopinath , Bjorn Andersson , Konrad Dybcio Cc: aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gaurav Kashyap References: <20251029-knp-crypto-v2-0-b109a22da4f7@oss.qualcomm.com> <20251029-knp-crypto-v2-3-b109a22da4f7@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251029-knp-crypto-v2-3-b109a22da4f7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI5MDA3MiBTYWx0ZWRfXxoutOPEZ20Av UIo1GSnvShvwjndf5+niEzG8mb+f8j142Fh97EZjpsPpnb70/MlhxbklCX9+DErKIAdvqEXYNi+ X2X4egQjho1X/tr1xa+twVm/y0mut0jrwJ1rysjq+e6vbxq+RDaxVZj4didtgSqO2esHZjrpiOH NfT04q9CsePobja28ew2xepkqmUuFqSkh9qUNARNpbqwS8Pq23X6h0QATsgfDbJ+hrPOQhuVb/y 1mYcgMhzyQH2l7TCa0BkAhVQ2ymOBkP0vhMftd9Gyj0Y2IqdtnMbhj0hVG2q2kTWlNJVzBRlb5/ HZmuEOJj5KwIsO4Ry5DpbJViM03sixjwoRjdkqba1Da5F5paX+yxmF280njUMP+nOPHCtEVTE5Y YT6krk5hjEKSpYoJRMvdTCPYP1JinA== X-Proofpoint-GUID: kDj-WZNKZNVB0Zor04Eu65pLms_ndqWe X-Proofpoint-ORIG-GUID: kDj-WZNKZNVB0Zor04Eu65pLms_ndqWe X-Authority-Analysis: v=2.4 cv=epXSD4pX c=1 sm=1 tr=0 ts=6901e160 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ostB5tDCqmNsE4DHYKIA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-29_04,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510290072 On 10/29/25 9:25 AM, Jingyi Wang wrote: > From: Gaurav Kashyap > > The previous version check made it difficult to support newer major > versions (e.g., v6.0) without adding extra checks/macros. Update the > logic to only reject v5.0 and allow future versions without additional > changes. > > Signed-off-by: Gaurav Kashyap > Signed-off-by: Jingyi Wang > --- > drivers/crypto/qce/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index e95e84486d9a..b966f3365b7d 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -21,7 +21,6 @@ > #include "sha.h" > #include "aead.h" > > -#define QCE_MAJOR_VERSION5 0x05 > #define QCE_QUEUE_LENGTH 1 > > #define QCE_DEFAULT_MEM_BANDWIDTH 393600 > @@ -161,7 +160,7 @@ static int qce_check_version(struct qce_device *qce) > * the driver does not support v5 with minor 0 because it has special > * alignment requirements. > */ > - if (major != QCE_MAJOR_VERSION5 || minor == 0) > + if (major == 5 && minor == 0) > return -ENODEV; This also allows major < 5, should we add a second check to reject that? Konrad