mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Gabriel Krisman Bertazi <gabriel@krisman.be>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] unicode: add MODULE_DESCRIPTION() macros
Date: Thu, 20 Jun 2024 16:48:20 -0700	[thread overview]
Message-ID: <a42047c6-067a-455d-b32a-a715ef41b004@quicinc.com> (raw)
In-Reply-To: <87v823npvl.fsf@mailhost.krisman.be>

On 6/20/2024 4:41 PM, Gabriel Krisman Bertazi wrote:
> 
>> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>
>>> Currently 'make W=1' reports:
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/unicode/utf8data.o
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/unicode/utf8-selftest.o
>>>
>>> Add a MODULE_DESCRIPTION() to utf8-selftest.c and utf8data.c_shipped,
>>> and update mkutf8data.c to add a MODULE_DESCRIPTION() to any future
>>> generated utf8data file.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>> Note that I verified that REGENERATE_UTF8DATA creates a file with
>>> the correct MODULE_DESCRIPTION(), but that file has significantly
>>> different contents than utf8data.c_shipped using the current:
>>> https://www.unicode.org/Public/UNIDATA/UCD.zip
>>
>> Thanks for reporting this.  I'll investigate and definitely regenerate
>> the file.
> 
> Now that I investigated it, I realized there is perhaps a
> misunderstanding and not an issue. I just tried regenerating utf8data.c
> and the file is byte-per-byte equal utf8data_shipped.c, so all is
> good.
> 
> Considering the link you posted, I suspect you used the latest
> unicode version and not version 12.1, which we support.  So there is no
> surprise the files won't match.
> 
>> The patch is good, I'll apply it to the unicode code tree
>> following the fix to the above issue.
> 
> Applied!
> 
> ty,
> 
yes, I was using current data.
thanks for taking the patch -- two more files to color green in my spreadsheet :)

  reply	other threads:[~2024-06-20 23:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 18:48 Jeff Johnson
2024-05-27 20:40 ` Gabriel Krisman Bertazi
2024-06-20 23:41   ` Gabriel Krisman Bertazi
2024-06-20 23:48     ` Jeff Johnson [this message]
2024-07-23 18:45     ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a42047c6-067a-455d-b32a-a715ef41b004@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=gabriel@krisman.be \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®