From: bot+bpf-ci@kernel.org
To: pilgrimtao@gmail.com,martin.lau@linux.dev,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,song@kernel.org,yonghong.song@linux.dev,john.fastabend@gmail.com,kpsingh@kernel.org,sdf@fomichev.me,haoluo@google.com,jolsa@kernel.org,shuah@kernel.org,chengkaitao@kylinos.cn,linux-kselftest@vger.kernel.org
Cc: bpf@vger.kernel.org,linux-kernel@vger.kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH v3 1/6] bpf: Introduce the bpf_list_del kfunc.
Date: Mon, 2 Mar 2026 13:32:17 +0000 (UTC) [thread overview]
Message-ID: <a4316335c76275e884a40fd0b2d1a7b2b4e35fb6fb80944d45e2bbc1e5a29c70@mail.kernel.org> (raw)
In-Reply-To: <20260302124028.82420-2-pilgrimtao@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
[ ... ]
> @@ -4080,20 +4100,25 @@ int btf_check_and_fixup_fields(const struct btf *btf, struct btf_record *rec)
> int i;
>
> /* There are three types that signify ownership of some other type:
> - * kptr_ref, bpf_list_head, bpf_rb_root.
> + * kptr_ref, bpf_list_head/node, bpf_rb_root.
Should "bpf_list_head/node" be just "bpf_list_head" here? bpf_list_node
doesn't signify ownership of another type -- it is the type that is
owned.
The unmodified paragraph just below still says:
"Hence we only need to ensure that bpf_{list_head,rb_root} ownership
does not form cycles."
And further down in this same function:
"A type can only _own_ another type in user BTF if it has a
bpf_{list_head,rb_root}. Let's call these root types."
Both correctly exclude nodes from the ownership types.
> * kptr_ref only supports storing kernel types, which can't store
> * references to program allocated local types.
> *
> * Hence we only need to ensure that bpf_{list_head,rb_root} ownership
> * does not form cycles.
> */
[ ... ]
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22576595943
AI-authorship-score: low
AI-authorship-explanation: Slightly formal commit message phrasing is consistent with non-native English; code and multi-version iteration strongly suggest human authorship.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Inaccurate comment in btf_check_and_fixup_fields incorrectly describes bpf_list_node as signifying ownership, contradicting other comments within the same function; no runtime impact.
next prev parent reply other threads:[~2026-03-02 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 12:40 [PATCH v3 0/6] bpf: Extend the bpf_list family of APIs Chengkaitao
2026-03-02 12:40 ` [PATCH v3 1/6] bpf: Introduce the bpf_list_del kfunc Chengkaitao
2026-03-02 13:32 ` bot+bpf-ci [this message]
2026-03-02 15:19 ` Mykyta Yatsenko
2026-03-03 1:15 ` Chengkaitao
2026-03-03 1:22 ` Alexei Starovoitov
2026-03-02 12:40 ` [PATCH v3 2/6] selftests/bpf: Add test cases for bpf_list_del Chengkaitao
2026-03-02 12:40 ` [PATCH v3 3/6] bpf: add bpf_list_add_impl to insert node after a given list node Chengkaitao
2026-03-02 12:40 ` [PATCH v3 4/6] selftests/bpf: Add test case for bpf_list_add_impl Chengkaitao
2026-03-02 12:40 ` [PATCH v3 5/6] bpf: add bpf_list_is_first/last/empty kfuncs Chengkaitao
2026-03-02 12:40 ` [PATCH v3 6/6] selftests/bpf: Add test cases for bpf_list_is_first/is_last/empty Chengkaitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4316335c76275e884a40fd0b2d1a7b2b4e35fb6fb80944d45e2bbc1e5a29c70@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chengkaitao@kylinos.cn \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=pilgrimtao@gmail.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®