From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=67.231.153.30 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792993735; b=4hfEOREwWAlwkL9fP8BDIEa4w661bhJ2acJ9w2WYZ9yGUo1PKvT7M1ATPxsH1DC+Xrve dVIp5R/mHzYfTWTbbmmE3XF8VWKpql2OKmuJExGqndPGptb+FOfHfFp8TBCwG7RGtTCXV qsbJlDbev0zVWoSuZWEI1vbVY8mA+KFQaL3Kg7EiDe/YGuiF40//AbB04XT3ogT/3gen4 JhySmHnpFroklbT06ZR6Al3t23SbbybErzUgLBtBhHWHl35XKAzmJY4QdcgGtEbpYci/O 85dgx621nRwCV4NMDLdaPVrc4vKz9DlR+4Be8EyMIvqdhWzmMof1YHYtCxZjWyOVOCw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792993735; h=DMARC-Filter:Received:DKIM-Signature:Received:Received:From:To:CC: Subject:Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:Content-Type:X-Originating-IP: X-Proofpoint-GUID:X-Proofpoint-Spam-Info:X-Authority-Analysis: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Proofpoint-Virus-Version; bh=eLNIW2q6eZQY3XO2w2wt1tsAR45z7skuJjJhjqBR+08=; b=ZijQaMMFyW8tnco4OMc4/PslKRR9lqTdThme+2JgF1IhI9VPG/TyOYbp8Wwa4zfU7cdN vF2yOBpqE7nOC8Mzc0Pt4fimv6ocLM9mR3K1WZG5mf/g/oVDlKs9e7kXIS5Gmf5a6aocm XniVK6liNmZiXcTXIUdoVx1miEpciRd/tG7X5RhwNDqefVqJ0uBy/qCEI5NxygMJhvs2E W5nfponkgICfL+Ao8f+w8KMj3U7rLEJ4sIR0ct/dNQSA+Sn7DlIK2mZFtgimC3i75BwMV hAIeIy3/Q8KSFG46qwa5rGax5Nq8/CjoF9X4DI/kXuV+jc+wRPENhn8A1dtTooLQhmg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=fb.com; spf=pass smtp.mailfrom=meta.com; dkim=pass header.d=fb.com header.i=@fb.com header.a=rsa-sha256 header.s=pps82601-s2048-2026-q3 header.b=hYsoL8Cy; arc=none smtp.remote-ip=67.231.153.30 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B66D60A2622; Mon, 26 Oct 2026 05:48:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4B66D60A2622 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fb.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meta.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=fb.com header.i=@fb.com header.a=rsa-sha256 header.s=pps82601-s2048-2026-q3 header.b=hYsoL8Cy Received: from pps.filterd (m0528005.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69Q38q5d2161746; Sun, 25 Oct 2026 22:48:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= pps82601-s2048-2026-q3; bh=eLNIW2q6eZQY3XO2w2wt1tsAR45z7skuJjJhj qBR+08=; b=hYsoL8Cy/J1Ql3fgbCHcaW+qM3lbO+k6VFlrCA4tUBvK0lYgdSS5K CYB3I/JTnSvy3KfNnok5lluD/v3hJuJyYeN0rGoXV/1TZVMto21ZIsKfxeCYVUZH lSOXk7kMsKcjE/yaQWm7Q1sNE/SP9zOYlRQF/vKMg8Y6+ugsM30cjm98QQr5ABSk 0iUI0ZroaQJlNZqJDzEgXKvt3NlH18kP9FMh5EKGoFHhgWtDPYoyLiIKhLMBWrt0 01NVr05AFcvJYJF0FfKc76jDl8mVF0yLHRAXodKuCBUygDoknEpHQH1Pw3P5XPIx c8Ez773vLUG0AlFRZ110czCbKYkXqKurQ== Received: from mail.thefacebook.com ([163.114.134.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 4hhe8h3bh2-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sun, 25 Oct 2026 22:48:40 -0700 (PDT) Received: from localhost (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c08b:78::c78f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.56; Mon, 26 Oct 2026 05:48:40 +0000 From: Amir Ayupov To: James Clark , Leo Yan , Suzuki K Poulose , Mike Leach , Alexander Shishkin CC: Will Deacon , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Mathieu Poirier , Randy Dunlap , Shuah Khan , Daniel Pereira , , , , , Subject: [PATCH v4 6/7] coresight: etm4x: Report whether the PMU counts the external outputs Date: Sun, 25 Oct 2026 22:48:26 -0700 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: OE0FGOOpzl1a9VmxpuKfIA8nwIIvmeWD X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI2MDAyMiBTYWx0ZWRfX4vlBIjSebLVH TXkbglJfyai5Xrc1xSDUxl5PnAl6KwI0uzCPYEWxGHwoKh0tuogCNQm3218sTIvDzG7FfeXjD+3 yQ7lH8WM9UlOixIZok519uxMME6+YLE= X-Authority-Analysis: v=2.4 cv=MbD5KJ/f c=1 sm=1 tr=0 ts=6adee9b8 cx=c_pps a=CB4LiSf2rd0gKozIdrpkBw==:117 a=CB4LiSf2rd0gKozIdrpkBw==:17 a=660iZSQnnn4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=7x6HtfJdh03M6CCDgxCd:22 a=jCddH8ec0KUNCymVuxII:22 a=FOH2dFAWAAAA:8 a=-Z3dWT6n0Uiql5SQPSEA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI2MDAyMiBTYWx0ZWRfX1IX/suv48Ixu ErEriHa9fPCcN+4xic7oS85iiGHUXhYC4ZKjDJE/kvWKTVamzBnl6Vcx0rqcJRXYuMXEX6BeJUM aOBtBDqfl2BwmV8I1JmCGdNAl1sZMDzHdZ+prFlDGD+PmjrEmXaL9GrRTRvowKrVaUmMRrDxA0X wH1Vdhw7uw7a5q8N4mqcgtn70Wx3AkaBSTdorDAP+3B+JyhThWyzUwE5mfdhy0LYlhWtwIL5lHC 6RwtOo84nObcfk0pYod/Xv08SkGK+ILAY6PWYzaUjoqHmSDr0+cvQXo5jczhyiFd039DjbJ1qgJ hENRZzCP++jyXmDn48aJkw0oTXASVPk8Opv89s/B2UJukUuwxQdF8NcoBVnLnYM2dqLvZrrsS/1 t57k4vpA0KHHPixlBp9/VSA7djfY8yKHCy9C4VHEjlPyAS/BGoAtASBz+lPot6Y3S9aw2VzJkah Ywr9VCMTORTMmEvX9OA== X-Proofpoint-ORIG-GUID: OE0FGOOpzl1a9VmxpuKfIA8nwIIvmeWD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-26_01,2026-10-21_02,2025-10-01_01 Some CPUs count the trace unit's external outputs as the PMU common events TRCEXTOUT0-3 (0x4010-0x4013), which lets a configuration drive a PMU event from trace unit events. Other CPUs, Neoverse N1 for example, have no such events, and a feature relying on them would silently do nothing there. Detect at probe, on the trace unit's CPU, whether the PMU counts every external output: the trace unit has an external output for each of its events (caps.nr_event), and pmuv3_event_implemented() reports whether the PMU implements TRCEXTOUTn. Only check ETE: per its specification, an implemented TRCEXTOUTn event counts external output n, while whether that output is also an external input is IMPLEMENTATION DEFINED. Add a CS_CFG_MATCH_CAP_TRCEXTOUT capability match flag, set it on those trace units, and show it in the feature's configfs 'matches' attribute. With capabilities matched separately from the device class, a feature that requires it only loads on those trace units. Assisted-by: Devmate:Opus-5.5 Signed-off-by: Amir Ayupov --- .../hwtracing/coresight/coresight-config.h | 2 ++ .../hwtracing/coresight/coresight-etm4x-cfg.c | 6 ++++- .../coresight/coresight-etm4x-core.c | 26 +++++++++++++++++++ drivers/hwtracing/coresight/coresight-etm4x.h | 3 +++ .../coresight/coresight-syscfg-configfs.c | 3 +++ 5 files changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-config.h b/drivers/hwtracing/coresight/coresight-config.h index 220bc54f8e5e1..4cf53230854d0 100644 --- a/drivers/hwtracing/coresight/coresight-config.h +++ b/drivers/hwtracing/coresight/coresight-config.h @@ -38,6 +38,8 @@ * a device that matches one of its classes and has all of its capabilities. */ #define CS_CFG_MATCH_CAP_MASK GENMASK_U32(15, 8) +/* the PMU counts the trace unit's external outputs as TRCEXTOUTn */ +#define CS_CFG_MATCH_CAP_TRCEXTOUT BIT(8) /* * Limit number of presets in a configuration diff --git a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c index 52cb036bb04b9..9e4dc5950c13d 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c @@ -176,9 +176,13 @@ static int etm4_cfg_load_feature(struct coresight_device *csdev, int etm4_cscfg_register(struct coresight_device *csdev) { + struct etmv4_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); struct cscfg_csdev_feat_ops ops; + u32 match_flags = CS_CFG_ETM4_MATCH_FLAGS; ops.load_feat = &etm4_cfg_load_feature; + if (drvdata->caps.trcextout) + match_flags |= CS_CFG_MATCH_CAP_TRCEXTOUT; - return cscfg_register_csdev(csdev, CS_CFG_ETM4_MATCH_FLAGS, &ops); + return cscfg_register_csdev(csdev, match_flags, &ops); } diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index af017bd8a5477..cb5fbb0279b88 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -1399,6 +1400,29 @@ static void etm4_fixup_wrong_ccitmin(struct etmv4_caps *caps) } } +/* + * Whether the PMU counts each external output of this trace unit as + * TRCEXTOUTn. The trace unit has an external output for each of its events. + * Only ETE is checked: per its specification, an implemented TRCEXTOUTn event + * counts external output n. + * + * Must run on the CPU that owns the trace unit. + */ +static bool etm4_pmu_counts_extout(struct etmv4_drvdata *drvdata) +{ + int n; + + if (!etm4x_is_ete(drvdata) || !drvdata->caps.nr_event) + return false; + + for (n = 0; n < drvdata->caps.nr_event; n++) { + if (!pmuv3_event_implemented(ARMV8_PMUV3_PERFCTR_TRCEXTOUT0 + n)) + return false; + } + + return true; +} + static void etm4_init_arch_data(void *info) { u32 etmidr0; @@ -1562,6 +1586,8 @@ static void etm4_init_arch_data(void *info) /* NUMCNTR, bits[30:28] number of counters available for tracing */ caps->nr_cntr = FIELD_GET(TRCIDR5_NUMCNTR_MASK, etmidr5); + caps->trcextout = etm4_pmu_counts_extout(drvdata); + coresight_clear_self_claim_tag_unlocked(csa); etm4_cs_lock(drvdata, csa); cpu_detect_trace_filtering(drvdata); diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h index 5417280cdb274..33994ad4b2641 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.h +++ b/drivers/hwtracing/coresight/coresight-etm4x.h @@ -868,6 +868,8 @@ enum etm_impdef_type { * @lpoverride: If the implementation can support low-power state over. * @skip_power_up: Indicates if an implementation can skip powering up * the trace unit. + * @trcextout: The trace unit is an ETE whose PMU counts its external + * outputs as TRCEXTOUTn. */ struct etmv4_caps { u8 nr_pe; @@ -907,6 +909,7 @@ struct etmv4_caps { bool atbtrig : 1; bool lpoverride : 1; bool skip_power_up : 1; + bool trcextout : 1; }; /** diff --git a/drivers/hwtracing/coresight/coresight-syscfg-configfs.c b/drivers/hwtracing/coresight/coresight-syscfg-configfs.c index 2b40e556be872..7b3800138f625 100644 --- a/drivers/hwtracing/coresight/coresight-syscfg-configfs.c +++ b/drivers/hwtracing/coresight/coresight-syscfg-configfs.c @@ -250,6 +250,9 @@ static ssize_t cscfg_feat_matches_show(struct config_item *item, char *page) if (match_flags & CS_CFG_MATCH_CLASS_SRC_ETM4) used += scnprintf(page + used, PAGE_SIZE - used, "SRC_ETMV4 "); + if (match_flags & CS_CFG_MATCH_CAP_TRCEXTOUT) + used += scnprintf(page + used, PAGE_SIZE - used, "TRCEXTOUT "); + used += scnprintf(page + used, PAGE_SIZE - used, "\n"); return used; } -- 2.52.0