From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932806AbcHYTDo (ORCPT ); Thu, 25 Aug 2016 15:03:44 -0400 Received: from sw.attotech.com ([208.69.85.34]:8552 "EHLO NOTESERV1.attotech.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932672AbcHYTDn (ORCPT ); Thu, 25 Aug 2016 15:03:43 -0400 From: Bradley Grove Subject: Re: [PATCH] scsi: don't reinitialize adapter's req_table To: Shawn Lin , Bradley Grove , jejb@linux.vnet.ibm.com, "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Date: Thu, 25 Aug 2016 14:45:31 -0400 In-Reply-To: <1471747164-31441-1-git-send-email-shawn.lin@rock-chips.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=windows-1252; format=flowed References: <1471747164-31441-1-git-send-email-shawn.lin@rock-chips.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on NOTESERV1/SERV/ATTO(Release 9.0 HF1131|December 16, 2014) at 08/25/2016 02:45:30 PM X-Disclaimed: 8879 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Bradley Grove On 08/20/2016 10:39 PM, Shawn Lin wrote: > req_table is allocate by kzalloc, so we don't need to > zero it again anyway. > > Signed-off-by: Shawn Lin > --- > > drivers/scsi/esas2r/esas2r_init.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c > index 78ce4d61..d6e53ae 100644 > --- a/drivers/scsi/esas2r/esas2r_init.c > +++ b/drivers/scsi/esas2r/esas2r_init.c > @@ -963,10 +963,6 @@ bool esas2r_init_adapter_struct(struct esas2r_adapter *a, > > /* initialize the allocated memory */ > if (test_bit(AF_FIRST_INIT, &a->flags)) { > - memset(a->req_table, 0, > - (num_requests + num_ae_requests + > - 1) * sizeof(struct esas2r_request *)); > - > esas2r_targ_db_initialize(a); > > /* prime parts of the inbound list */ > This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.