Re: [PATCH v23 08/15] media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY

[Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>]

On 10/31/2026 1:01 AM, Vladimir Zapolskiy wrote:
> Hello Hangxiang.
> 
> On 10/28/26 17:20, Hangxiang Ma wrote:
>> Add support for the v2.4.0 two-phase CSIPHY found on Kaanapali, where
>> the PHY is driven by the standalone phy-qcom-mipi-csi2 DPHY driver
>> rather than by CAMSS. Add the mipi_csi2_dphy_3nm_kaanapali configuration,
>> which reuses the x1e80100 lane sequence, clocks and supplies but selects
>> the v2.4.0 common status offset, adds Kaanapali power domain and register
>> the "qcom,kaanapali-csi2-phy" compatible.
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
>> ---
>>   drivers/media/platform/qcom/camss/camss.c | 47 +++++++++++++++++++++ 
>> ++++++++++
>>   1 file changed, 47 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/ 
>> media/platform/qcom/camss/camss.c
>> index a64242c66cf0..b0b63dd3d958 100644
>> --- a/drivers/media/platform/qcom/camss/camss.c
>> +++ b/drivers/media/platform/qcom/camss/camss.c
>> @@ -38,6 +38,51 @@
>>   static const struct parent_dev_ops vfe_parent_dev_ops;
>> +static const struct camss_subdev_resources csiphy_res_kaanapali[] = {
>> +    /* CSIPHY0 */
>> +    {
>> +        .csiphy = {
>> +            .id = 0,
>> +            .formats = &csiphy_formats_sdm845
>> +        },
>> +    },
> It makes no sense to bloat the code for no good reason, especially if
> these empty tables are to be added for every new supported platform.
> 
> CSIPHYs is not a part of the CAMSS on this platform, hence resources
> shall not be statically allocated for CSIPHYs in the CAMSS driver.
> 
> See also https://lore.kernel.org/linux-arm-msm/20261026224957.1115370-1- 
> vz@kernel.org
> 

ACK. Will include this and refine this series.

---
Best Regards,
Hangxiang