From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 658CE3BE17B for ; Tue, 19 May 2026 13:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779198820; cv=none; b=rsKj34UyA5C3Q9t089sH9DMoS4LWkZhAVdnc1LboRyy8DDSAqyeJyqsPWIMF97KwNcjGeifXQL3d0EJhHEJckKqbH2eALB4LWQooe3l0WCRZ2uq+EaOtBFkoB4/4Dz8awUR97TvvHTg/wniXnm3UBa4pUJ8YbojUt8kP/azYrMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779198820; c=relaxed/simple; bh=HNcI1kNzIGfM0x3r8RbKIKrdoY5+TDkvSLJtco1ZEO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Knze2SYbuk15xK9IGkIi3NUy7Wzm9MyNeY8gezRBbiK9hR0gxuqHcyCCEwtSFEZk4jB+jqGMMhhybKc9HmYbAUX/wJG3uBzOt9wwoKAYR6rdYyJNDNRt9PRHRR2yDdBPz5zhwvwzccq3JN+D8wKyns948G/1N0mb9h89EMOCLAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XBxhJYGQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RJrQRc32; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XBxhJYGQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RJrQRc32" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JAeJ1n4131492 for ; Tue, 19 May 2026 13:53:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SHd/seu6GWeewtLPWuKEX1k3PpnC+gd0X961ojf5+Tc=; b=XBxhJYGQgHoNEFMl 89KArmF0aZ/h9a2LoUeXhUrYySj9Y1oaF8J8BR7JC1ZWz8QTTHnSksW4EhBh4Jbx 9OTdEZVwd735yccEBgkFaekYCtS0lESzk8YcOQAQsC/9J39+sSF5e87uI8Wwjj57 weG/UlD/ZpTD8XudL+6M8ErVvAKzawCgqfi0PMvU7lFe+4+Av3jE/+PvpdH6A6Ce IQvAM7Sw8DTDoG63APSaxxA0faWxLTZU7ywBpi8xuezyMq9ggYz3s496JfVfVwsH QEchz1Y19grGgFYd87dOHI+0Ji4EMTLBAFW4t5lm/yMpWafVph5RTGdfcZiU5X1J Lvag9g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8ht1j2aw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 13:53:38 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36641bb3d97so2162092a91.3 for ; Tue, 19 May 2026 06:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779198818; x=1779803618; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SHd/seu6GWeewtLPWuKEX1k3PpnC+gd0X961ojf5+Tc=; b=RJrQRc32NXaansnrjr6KjIGI/+OIATs2GW3GW5IFQmg432KV4I98Uh7jqUnIvL35Vm dXB+cU+si9Vzs0Pmx+4FQwMbID9opJkvYDqYgiXw4y4TRYBKLlJmxXpgNeGBVzLf3X4z Gqn70lt+GO5HHcbeRDF8gOOfNEVFBbBaSygg7Vdh1n2LCehlLWQcNXPNXvVqsAlDqpXx 8+HlBKxtG77s9c1jbgbkBmrbF0euBd42c+eLuXsTpfibSyEVK+r6NCfIuZaKFY5c5u6v i1Z15V8gct+w0cGd/ASsCYvLE/G8Gt4xnTt0/o2TshlWid5/E3rmGTPbJsknOIp+Dx3O eE0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779198818; x=1779803618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SHd/seu6GWeewtLPWuKEX1k3PpnC+gd0X961ojf5+Tc=; b=GW8PVx4JnSiyasPfYdui0aDbRyvfwETHH85T1AF+1c25TATXeK4isW8spLdUEuHp7K wy+F0bV+HSKm86sO6oEds5offq6BjGswW4dXS2Q7mhRiTu+zOIOi6/CxVxjRn7u7UuQB 0FwvfP2OtlYZ/LcCV0Wcl/yx4w2ioJMwbRmpU9hljTBC17s5VqVgyQ6df5snjTq8+tyq Dwv5dzRq4warCpzvPAesnggKlKjCYSP0Z++CYNLB+XFFnCMHzZgsj/BXY9dShKuFJ6Rn YqrBT2+YZefWlmsWo1Wq6PY8ug8VWUrmoDn0R0EETIYGnoWXUZ7nksZ0nX8TWQIIcnQZ A79Q== X-Forwarded-Encrypted: i=1; AFNElJ+caVks8QAw8RKqB2DvqjQGrnBE+p8xrvjiiBVA7Hj/l9Ta3fZv7FI5RWUXVOf8hI4tuNzElE4jyMo+j8E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6wCZmOaO5NQSvTdvEceEH3vWIWui3FUCGAoiVmfPDa8XKMKWu n46fESa270urzRT7r6X5W36Xn0ufCb6XXC3Dq0do/5VCXGkWco0t7JUpG94kJ7j3/qBGWHHiQ95 daWy7AE7oLEVSC9HjNbuYTPDuh8F3LahHFPkEZbRUMC5UXGjrEurWpOg8PKlkO5mmtmg= X-Gm-Gg: Acq92OHrfSv5iyVRr6qUNavOYT+OThbZlN1f2aCVr+TAnyYDgGmGQdxQkPhZnRoKFf0 inCKSBFRmUVIRAcDJpVI3l9E9Cy1rgJsxFFb8fH14fw157dL8U/qFLpEu5iFPJZOv8lvTkWsoEf 3G1C7CaOHsyGgOv/ykmz54mm5dG8P2m1ejccdtf0lHCWO9g/hnB6TCSVEGakgx6VLUg5OlHpF+7 mPCYa2oqj9AX56Jyx5YZST0LaRuWyF6rtbWcKoB7AQa2d8UeTTomEVLUpp+65A6ZmIPr/Z3BNZ9 W+j0SWcPa9F9kNIF1mDb6N6bDm7mRfTdEAfipGcZJ7VmRvVm6LgsbCSA+TWx+hvdX2LSOloR+Ui DIVYdYgnwqNVl1cucpSmBfhJt8cK+kh1FLTSdxHAMFN1Ho4dx X-Received: by 2002:a17:90b:3505:b0:368:9da3:c496 with SMTP id 98e67ed59e1d1-36951ca7638mr19545340a91.24.1779198817954; Tue, 19 May 2026 06:53:37 -0700 (PDT) X-Received: by 2002:a17:90b:3505:b0:368:9da3:c496 with SMTP id 98e67ed59e1d1-36951ca7638mr19545289a91.24.1779198817413; Tue, 19 May 2026 06:53:37 -0700 (PDT) Received: from [10.219.56.98] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-369c4bb4d4dsm3568780a91.1.2026.05.19.06.53.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 06:53:37 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 19:23:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iommu: arm,smmu: Document optional interconnects property To: Krzysztof Kozlowski Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260516-smmu_interconnect_addition-v1-0-f889d933f5c1@oss.qualcomm.com> <20260516-smmu_interconnect_addition-v1-1-f889d933f5c1@oss.qualcomm.com> <20260518-mellow-robust-caterpillar-93fcaa@quoll> Content-Language: en-US From: Bibek Kumar Patro In-Reply-To: <20260518-mellow-robust-caterpillar-93fcaa@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JKULdcKb c=1 sm=1 tr=0 ts=6a0c6b62 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=E2rNws97cCCTNOQwQB8A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: iFbLAw1tpd_7hsc7lmXjLgJ3BouC6yG7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDEzNyBTYWx0ZWRfX1B4ksb1yTxEg xSBMpYCvhS5oDBqT2bnhkbGFAk4vKAOTAWdm0likkJF5uKWC90PD/W+x65pJrLLd17KPd4zZyqh Y9rzmPoPwuRFEn5rjpi9ZBhm1pnB8ilEcKfW2gxPJi+7L4z5AHiOSmYTuJT5FzPyFYx9r9lAqeI gR01CdEKCHpzSAIaSpxyW8G6su5IMWitBZ47YgX9iskD5q9aytGZij/Q7yg57u/VVittWvuVMrt cDZFxNS/2Mq+OPkzEjL7ghs7sF9p/MDTCPgBm4jxzS4jTAj5PYGjNjTiTml776C8ZyuCirZKTvq RwkxNWwmJ2kuqW5ofWOVh10IboMnmBKEPpNpkWpSMACxDPLkiaf+Kvhwn4Dt9WEtLLIRYpv6qu0 n37tFSHHyir3D+hl8am+yL5zJ2u6NVhOR8tULR92dfa3Ojom7JzLO2+hUIEyPoY2YPbCqzeNrWf FWbmIDjEtZSLT2P3Rww== X-Proofpoint-ORIG-GUID: iFbLAw1tpd_7hsc7lmXjLgJ3BouC6yG7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190137 On 5/18/2026 6:03 PM, Krzysztof Kozlowski wrote: > On Sat, May 16, 2026 at 06:04:03PM +0530, Bibek Kumar Patro wrote: >> Some SoC implementations require a bandwidth vote on an interconnect > > Then this should be disallowed for other devices in "allOf:". > As of now, we still are checking which all SoCs do not need this interconnects field. So would we need to add the allOf here for now? >> path before the SMMU register space is accessible. Add the optional >> 'interconnects' property to the binding to allow platform DT nodes >> to describe this path. >> >> The arm-smmu driver uses these properties to vote for bandwidth before >> accessing any SMMU registers and releases the vote on runtime suspend. >> >> Signed-off-by: Bibek Kumar Patro >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 06fb5c8e7547cb7a92823adc2772b94f747376a6..5cbf944f2d3e178b3723d4dbaa19ee0d33446979 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -243,6 +243,15 @@ properties: >> minItems: 1 >> maxItems: 3 >> >> + interconnects: >> + maxItems: 1 >> + description: >> + Optional interconnect path to the SMMU register space. On some SoCs >> + the SMMU registers are only accessible after a bandwidth vote has been > > Drivers are irrelevant here, drop. Also first sentence is redundant. > Schema says what is and what is not optional. > Sure, got it. I will remove the "driver" quotation and "optional" wording from both binding description and commit text. Thanks & regards, Bibek > Best regards, > Krzysztof >