From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D86EC433FE for ; Thu, 14 Apr 2022 21:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245481AbiDNVv0 (ORCPT ); Thu, 14 Apr 2022 17:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232439AbiDNVvY (ORCPT ); Thu, 14 Apr 2022 17:51:24 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2045C954B9 for ; Thu, 14 Apr 2022 14:48:59 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id z6so6889975iot.0 for ; Thu, 14 Apr 2022 14:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OmTrbVZbb3w4KmRSUrb4q7Rzh5oX9eyi3T1MDFP0KjU=; b=L0ITK16Dy0IulWrdQyDKQ385h5ypzAheqavuhQtIQ4WthfcqHAKDNmY714eWVBWVkd 0lH5+srAWBGwoZGuRFGvxgF5ndFpH5MI5HwM+B2POrV/utMgPDIQYEMYFpwBaugtYjn3 RKd+NKmkrd+Wq7xUVVUwT07zs/glJxUNPjTEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OmTrbVZbb3w4KmRSUrb4q7Rzh5oX9eyi3T1MDFP0KjU=; b=zUes6rHAzm3G+CqikNLvkpzsRkcCVyJ02B1x4wkhCMti30q0lmzd7Zl/kgnyG2AkWZ p6goVS5wvtvZ63bkGI94gSLL++hnFfB4a0xLjzVgPpvFGLxmGInSQjvjHGw/Xwqslhm6 o1b8FMeb/VbQ39zi1Y4mf6lwh0rkRrnW5dl3GLAQYIcQ9X3Qz46upHUlcLEkPdqMwhFv ypsqYsyB1jEtXZHNDXXhh5DUOdQG76OF/X5GXE1qjBpaaKZz5pslkDAN8TIzBD3CnrCO 0qQB0n4OcURBcKB8BIO9APRUMId+XPJ/6ibmMcTDERtyjvwThOLf6+fZejmZUtu7QaPD ZYfw== X-Gm-Message-State: AOAM531yutelHgYO6E2vl8drj4uv+x2YUJWgJn7P7iPFbaezekv0ImMu +aBbjVTRiSHnUzpALsdylJv7Cw== X-Google-Smtp-Source: ABdhPJwFB9gnU6H5kQKv6sg6zZUUef1cdcX0RES3LTxpZRh8PGSuFNjTFiSA6oTKwMbW7jV7ifdjtA== X-Received: by 2002:a05:6638:2047:b0:323:7f2c:f5c4 with SMTP id t7-20020a056638204700b003237f2cf5c4mr2095401jaj.88.1649972938520; Thu, 14 Apr 2022 14:48:58 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id w3-20020a92d2c3000000b002cbca0cd15fsm1681010ilg.8.2022.04.14.14.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 14:48:58 -0700 (PDT) Subject: Re: [PATCH 3/4] selftest/vm: support xfail in mremap_test To: Sidhartha Kumar , shuah@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220414171529.62058-1-sidhartha.kumar@oracle.com> <20220414171529.62058-4-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Thu, 14 Apr 2022 15:48:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220414171529.62058-4-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/22 11:15 AM, Sidhartha Kumar wrote: > Use ksft_test_result_xfail for the tests which > are expected to fail. > Same Nit about commit log lines. > Signed-off-by: Sidhartha Kumar > --- > tools/testing/selftests/vm/mremap_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c > index 98e9cff34aa7..ace9c3596ed7 100644 > --- a/tools/testing/selftests/vm/mremap_test.c > +++ b/tools/testing/selftests/vm/mremap_test.c > @@ -269,7 +269,7 @@ static void run_mremap_test_case(struct test test_case, int *failures, > > if (remap_time < 0) { > if (test_case.expect_failure) > - ksft_test_result_pass("%s\n\tExpected mremap failure\n", > + ksft_test_result_xfail("%s\n\tExpected mremap failure\n", > test_case.name); > else { > ksft_test_result_fail("%s\n", test_case.name); > Thank you. Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah