Re: [PATCH] power: energy_model: Rework the depends on for CONFIG_ENERGY_MODEL

[Lukasz Luba <lukasz.luba@arm.com>]

On 12/19/24 09:11, Xuewen Yan wrote:
> From: Jeson Gao <jeson.gao@unisoc.com>
> 
> Now not only CPUs can use energy efficiency models, but GPUs
> can also use. On the other hand, even with only one CPU, we can also
> use energy_model to align control in thermal.
> So remove the dependence of SMP, and add the DEVFREQ.

That's true, there are 1-CPU platforms supported. Also, GPU can have
the EM alone.

> 
> Signed-off-by: Jeson Gao <jeson.gao@unisoc.com>
> ---
>   kernel/power/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index afce8130d8b9..c532aee09e12 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -361,8 +361,7 @@ config CPU_PM
>   
>   config ENERGY_MODEL
>   	bool "Energy Model for devices with DVFS (CPUs, GPUs, etc)"
> -	depends on SMP
> -	depends on CPU_FREQ
> +	depends on CPU_FREQ || PM_DEVFREQ
>   	help
>   	  Several subsystems (thermal and/or the task scheduler for example)
>   	  can leverage information about the energy consumed by devices to

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>