From: "Alexander Beregalov" <a.beregalov@gmail.com>
To: "Randy Dunlap" <randy.dunlap@oracle.com>
Cc: mingo@elte.hu, yhlu.kernel@gmail.com, tglx@linutronix.de,
hpa@zytor.com, kernel-janitors@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 setup.c: cleanup includes
Date: Mon, 7 Jul 2008 00:29:36 +0400 [thread overview]
Message-ID: <a4423d670807061329m6b9dfd69if2e48aa7b3be599b@mail.gmail.com> (raw)
In-Reply-To: <20080706105840.90ac5219.randy.dunlap@oracle.com>
2008/7/6 Randy Dunlap <randy.dunlap@oracle.com>:
> Did you do these manually (by personal inspection) or by some tool?
> If a tool, what tool/where is it? Thanks.
It is a simple script like this:
find . -name "*.h" -exec grep.sh {} \;
find . -name "*.c" -exec grep.sh {} \;
grep.sh:
#!/bin/sh
grep -H "^#include" $1|sed "s,/\*.\+,,"|grep -v ":$"|sort|uniq -c|grep
-v "^ \+1:"
I have found about 70-80 double inclusions, but most of them have
reason for that and can not be removed.
next prev parent reply other threads:[~2008-07-06 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 16:13 Alexander Beregalov
2008-07-06 17:58 ` Randy Dunlap
2008-07-06 20:29 ` Alexander Beregalov [this message]
2008-07-18 16:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4423d670807061329m6b9dfd69if2e48aa7b3be599b@mail.gmail.com \
--to=a.beregalov@gmail.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®