From: "Alexander Beregalov" <a.beregalov@gmail.com>
To: "Ian Romanick" <ianr@q7.com>
Cc: "Mark Asselstine" <asselsm@gmail.com>,
airlied@linux.ie, dri-devel@lists.sourceforge.net,
kernel-janitors@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm_memory.h: remove double inclusion of linux/vmalloc.h
Date: Tue, 8 Jul 2008 20:56:00 +0400 [thread overview]
Message-ID: <a4423d670807080956m4aa548b7vf5557892aae81432@mail.gmail.com> (raw)
In-Reply-To: <20080708152225.GA9028@q7.q7.com>
2008/7/8 Ian Romanick <ianr@q7.com>:
> On Tue, Jul 08, 2008 at 08:29:57AM -0400, Mark Asselstine wrote:
>> On Sun, Jul 6, 2008 at 7:31 AM, Alexander Beregalov
>> <a.beregalov@gmail.com> wrote:
>> > From: Alexander Beregalov <a.beregalov@gmail.com>
>> >
>> > #if __OS_HAS_AGP
>> >
>> > -#include <linux/vmalloc.h>
>> > -
>>
>> Why remove this one and not the one at the top of the file? As well
>
> I would assume this one is removed because it is inside additional
> ifdefs.
Yes, it does not change functionality of the code.
>
>> this file has #include of drmP.h, yet drmP.h is the only file I can
>> find that includes drm_memory.h. Based on this I would think there is
>> some additional cleanup that can go on here.
How it can be cleaned up? Do you mean to move `define PAGE_AGP` to drmP.h?
next prev parent reply other threads:[~2008-07-08 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 11:31 Alexander Beregalov
2008-07-08 12:29 ` Mark Asselstine
2008-07-08 15:22 ` Ian Romanick
2008-07-08 16:56 ` Alexander Beregalov [this message]
2008-07-09 0:28 ` Mark Asselstine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4423d670807080956m4aa548b7vf5557892aae81432@mail.gmail.com \
--to=a.beregalov@gmail.com \
--cc=airlied@linux.ie \
--cc=asselsm@gmail.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=ianr@q7.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®