From: Alexander Beregalov <a.beregalov@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf: add close()/closedir() calls when needed
Date: Fri, 8 Jan 2010 01:44:59 +0300 [thread overview]
Message-ID: <a4423d671001071444k2cb61c0blb1bb175ab0098a9f@mail.gmail.com> (raw)
In-Reply-To: <20100107212912.GB10344@brick.ozlabs.ibm.com>
2010/1/8 Paul Mackerras <paulus@samba.org>:
> On Thu, Jan 07, 2010 at 07:40:46PM +0300, Alexander Beregalov wrote:
>
>> Close file and directory descriptors before exiting or dying.
>
> Your patch description doesn't say why that's a good thing to do, and
> it's not obvious to me at least. Please explain the motivation in
> your patch description.
Isn't it a good style to close files after use and before exit?
next prev parent reply other threads:[~2010-01-07 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 16:40 Alexander Beregalov
2010-01-07 16:40 ` [PATCH 2/2] perf: fix memory leak: counterwidth Alexander Beregalov
2010-01-13 10:35 ` [tip:perf/core] perf: Fix " tip-bot for Alexander Beregalov
2010-01-07 21:29 ` [PATCH 1/2] perf: add close()/closedir() calls when needed Paul Mackerras
2010-01-07 22:44 ` Alexander Beregalov [this message]
2010-01-07 23:54 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4423d671001071444k2cb61c0blb1bb175ab0098a9f@mail.gmail.com \
--to=a.beregalov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®