From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3998F5013A7 for ; Wed, 16 Sep 2026 16:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789575219; cv=none; b=q6tt9VI0QSfZ1RKjB1Wr1lgV4OmMlSUDbZnSluxl2v6zOedCccql8XXbBCerDrPJ18P80AOIPHcBKhl0IXeKM2atG4CeVPqPDF9E+fVJvsO+Uk0pTpGiNd8u6sbtoCStXIs2cQFwm5I9e/FWQfH+78SpxYMkd770e9+sAjLV5AY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789575219; c=relaxed/simple; bh=bvzruHOER+tqBVKqHVqUWmL8gkxbGAQ2vbFxKDXxPC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hRa7D/4bRfoGmjq5L97kWcgVWObsJhdMfVccQGLCeBJzKybuz6Z5AHqGpuD7keCnGgVzn3nTikB8644KJYonASElbBAg8qzcP1olUbI6tY3z0rKo1AjDIIFfouicczuvIcBOVeDftMmY1F6TKZ/bNc4izm3krXosf5U/CEuo43k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DHv39bTn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XX0y1Bi1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DHv39bTn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XX0y1Bi1" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68GFeJev067674 for ; Wed, 16 Sep 2026 16:13:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7D4/ywcwxqoIaD2knicVl0ONbCnWnKh8GAaiP1pjZEw=; b=DHv39bTnzaHvBHmd ShUgZGfYOYR9RcSKsUy5DG0vfhX3rIv7tn8p+Wp0CQtTZMPofacDOghO0xmw9WH3 XMF5pghRjTbOXG2TuClcGj7Gwce8bsqX8vZ2yT3kVkePGGIbxM8hTpMlNJHUnO47 O161PPoDd//+rcxVg9mUWcIfKNLyQHYTzWoF1A2DuBeM+OSYXgzbSlBgwsJWegeR KhRorZ1KV+F4MHkeMX7VHnGU6NsvqlJXVZKC9SSO0Ap4W4cnXnTOaWD6/alxLI66 uQtkLns62xgSuIAajS1pOhpd+B6IPNHLTK4sk4rocYdyJkqINTBaVrBR1CPMBL31 6FpqGA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqefpc3gc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 16:13:36 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9375d92d0caso91915785a.0 for ; Wed, 16 Sep 2026 09:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789575215; x=1790180015; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7D4/ywcwxqoIaD2knicVl0ONbCnWnKh8GAaiP1pjZEw=; b=XX0y1Bi1m0T9UAbOKXu6dJadeUEZfAA5qxn30bW2/PHNBXKDnUV23qsG3GZIIqs9zy uS6m+cfYVWsG9xZv50tPcoL4d/QhfV4ataS7qJxkB+p8BThPXBFyi9awkmBPC1d1DT2X bZGU0f4mej4CCjUjsM+gvrP878prI+7/Hl0VSm/Z9CdHjeOyleI9Fhqa0Wtj93pSIhS4 DX7Bg+Mh/nUgMah3Wk9dQ2+9nsRjh2x9eLdyUJ1OetmRJiHCup4nE7Ereu+oLUQFy4TZ VWsYXmZ92Kkvc4LX0V79R+Nm698dNqbb+GJwkpTIoUdPMchjjh8WP1p3dIgfJYGbjkFo 2dlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789575215; x=1790180015; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7D4/ywcwxqoIaD2knicVl0ONbCnWnKh8GAaiP1pjZEw=; b=fbh1MbIH7OuSvm5eQVtPaasLa40ZYypxmZ0UtFyUyQ3xl58kaweu/OytZZu5qkSBXu J1M9/bC1l2eUzek/eT3HaUIoWDvXm8W9/WjI48YjgodbrUyz5/6tFyl4UtEVwUCyL2MJ opfk7I9Sqhl6EpJ0oqnMhBhtQDIlkw2dBlcXmsggNPrlz/5yb3Ov08khtIzWIfA965kN srVUuio+2s9ahm5v25YDkNvz+/Q13Ak/VkLhJMQqOR2UwawGcU1K5J0vmfP6XMPJKQ/A /vj2UXms4Bz47bZcdLXOHYqL58mMKPNtu16zyfLifOJGnhSBSRRlS/JdVkdjwbVVZ9Qk 7yCg== X-Forwarded-Encrypted: i=1; AKwUvBzyIvCktduCFoZh4R34F/mTONxLnffvx4HXl3nUXlYl8PQT+5DTXaVNPNsZdp+kIS3I/N94QMLj+ckqnQc=@vger.kernel.org X-Gm-Message-State: AFuF++mWDBbA8wI/3WVnZjaccw/s8VVUW6gs4zywgB+kKVfyrUPMEJJE EiWWGzMpa2I752x01kKZ6dGKOzzqCrf3k8UOOOiprKAvKb5SpNxbLedfBM7bCIJ7v9iLt3HRAtw 1NclduTt/ZE1Cx4ye2fBijq0GtA0hBX7Sgh7kr2TE+7bepFzyKAuB/3vKoMc5fA+j96o= X-Gm-Gg: AYBFou2UqYAef8aWplErnKMLeaHcol6n7lI8o4Ya3mO1jIK0OD0kqNAKHh84lFt3ui+ /kkl6dgYrfCtKh4vVfF4pVk/EZOKLoYRYcdT2tL77EYlRp3WnnKwRfG9Xx1XLWhKGvUfo6/8wo7 efh4GFHvHBRLQB1p75SlpNoo+TQYkvAI17UyTjL6x0IoUmg+xKd3xGylzhMfplR6hcKCxs6/KqG uIU5XKYXZhg1eb5IAyW6hoUAhLnh1N/rv4KhWcHBwdS2dqnYGKzWdyNbCbN9i5BGuWglG7qM+u6 7AcnOICsW2c4E7sZx9YltaAX/rvZHs6H/ZsfQ5I7Q2704uKayGIY+JQIY8OaoSCMVh5LYIlUQUS 62+AXyXothqlKPdNRlLOzBg== X-Received: by 2002:a05:620a:19a0:b0:939:c8b8:4639 with SMTP id af79cd13be357-93bb7963962mr456734285a.4.1789575215381; Wed, 16 Sep 2026 09:13:35 -0700 (PDT) X-Received: by 2002:a05:620a:19a0:b0:939:c8b8:4639 with SMTP id af79cd13be357-93bb7963962mr456729485a.4.1789575214958; Wed, 16 Sep 2026 09:13:34 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b8b57c3600sm1021028e87.24.2026.09.16.09.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2026 09:13:32 -0700 (PDT) Message-ID: Date: Wed, 16 Sep 2026 18:13:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Ignore -ENODEV after Root Port reset To: Niklas Cassel Cc: Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krishna Chaitanya Chundru , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam References: <20260916-topic-pcie_portrec_enodev-v1-1-5dc7bde39552@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDIyMCBTYWx0ZWRfX7ljY541CnKpy QJfd3fCceRpk1Fnc1srzFezXr1fXBJb8DDmynn9/7wVOVQuInJdOCNf5lo6Fp0/UgYAZKb5UYS8 2UnNB1V8+KqiVLRMDW7AXcy4Q2qn0cw= X-Authority-Analysis: v=2.4 cv=HrTjiETS c=1 sm=1 tr=0 ts=6aaac030 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=rHa_6ZUMNKMLsCsp4AwA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: -6mvstV4t8Kr7s43T8DisO815d2bVG4T X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDIyMCBTYWx0ZWRfXxtz4Nzic81PA 9/BQd2UQ/d8iiCEW0LO8yEf1QFP6nIFwz/vzQoFmVWr0g7ZterkCk2MrCX2kmLF1NkIOOZRGbxu 40eGkOyzjTCMORrgec46tPHT+AqE4dCIrhn0rvyw45P7ZlNEW9M00/OCp2DyQuaS4NGXJON1Ou4 MxpRWxQAxacLwz5E7amJwDviUcNGDnDjHs8lNO+8OhPTkTFLx59w4X8vAUzZC2Gk3z44WtHnEIM Oz71Osf6BLi6TjwE3jdGiV1JvleLLDZGwu/PiaNSGRtQYruWPoqZeQRF9QDfP3uS9TXPPAlEkKq T0rIQT7iszIHuIXjzHdQZK7qsmlysWU+DeS3k2fNCGHDruJKyt/ffBv/KareiXEN91dCbygFQtZ A3tdigyOaLgINh68LL1qEEFtF+B+EZjSUTF6oDWhotvPNJjnvOtzF48U2lIrdHcI5Z98E/pH0Fa GzNMmDyPKsPaFPTm/dg== X-Proofpoint-GUID: -6mvstV4t8Kr7s43T8DisO815d2bVG4T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-16_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160220 On 9/16/26 5:53 PM, Niklas Cassel wrote: > Hello Konrad, > > On Wed, Sep 16, 2026 at 02:37:49PM +0200, Konrad Dybcio wrote: >> Root Port recovery may race with a device hot-unplug. In that case, >> dw_pcie_wait_for_link() returns -ENODEV because no device is detected >> after the controller has been successfully reset. >> >> This is a valid outcome and should not cause Root Port recovery to >> fail. Ignore -ENODEV while continuing to propagate other link-training >> errors. >> >> Assisted-by: LLM >> Fixes: 4d88cb82a6d9 ("PCI: qcom: Implement .reset_root_port() and use for link down") >> Signed-off-by: Konrad Dybcio >> --- >> drivers/pci/controller/dwc/pcie-qcom.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c >> index ee63a6ec99de4d07c16b8d6cb68df0d92f822cd8..3d3be9bf798b7c247d69969d6570385b8648123f 100644 >> --- a/drivers/pci/controller/dwc/pcie-qcom.c >> +++ b/drivers/pci/controller/dwc/pcie-qcom.c >> @@ -1880,6 +1880,9 @@ static int qcom_pcie_reset_root_port(struct pci_host_bridge *bridge, >> qcom_pcie_start_link(pci); >> >> ret = dw_pcie_wait_for_link(pci); >> + /* This linkdown might have been a hot-unplug */ >> + if (ret == -ENODEV) >> + ret = 0; >> if (ret) >> return ret; > > > I did not know that pcie-qcom supported hotplug. > > Last when I was discussing this with Mani, I'm quite sure that he said that > it doesn't, see: > https://lore.kernel.org/all/20251222064207.3246632-8-cassel@kernel.org/ I don't know if native ports still don't, but the ones used for USB4 tunneling certainly do see e.g.: 65ccb2203ef8 ("PCI: qcom: Clear Attention Button Present in Slot Capabilities") Konrad