From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECAEE2629D; Thu, 12 Sep 2024 10:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726135474; cv=none; b=JXkoLrvRsm5xX5puvIGj6duzh4Mc7GTEJwKPoT1s5lbVnKcfTuf60QE1D+fNYhJSOkA+QNCu6K6++8bNaesP4FuxvbdUG1uHo3Xxz0Wf5CEYS0ldWxhGouGBA30xyFOwF+u+EbKzKYu7zw7O3a3lQcYLnKJgBxLxcI1lRtBGAw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726135474; c=relaxed/simple; bh=dQyXJBIYNaZ6LY9RHX0RYltSusVdJc0TuS6GZBraPCQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=uj3iWXdmazCE1baROFHBK0aqbQDLOindnqEDHP9OrQm3ASePStRGDtuMgOTF46SC1fCJyZA6I1S2hq06euy9DQpWGIeIR7sTabOzwv/4Yq16mK64k8CqCLec5nvZsofoTmH2GDkgTODQXHkJ4UXdbSg4vIgKgVB+MJHGoPkn1Qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=U0hN9YxG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="U0hN9YxG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48C2Kvj5014368; Thu, 12 Sep 2024 10:04:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VgDaiO5dsUWlvwNygpxWUDFb/pwkhCdZTux83IGLIMo=; b=U0hN9YxGCrd38Jt6 /fYvEsdIpvhEIY+EZHv3BPqIikhnW8+6VdKiCQIx5e3/dFf0iQjslJmPHGeIHTS9 IlfYw1EUIgE9iduwntHT19MvOdphzsBhfLWoTVyxu8/V/sji3/S+ie62piYyTnxG /zB+XnB9r6hDHN9V/KD3se/0FthfF/5ggkhP+Z7yDJiIKeNvIDwohhxIbpRv3Jcg FMq/11ilte1BUPi4nRRCHgKXvOaN4WROKW1gq2I0HipeS3RUPk9/JELCLzIF+7PT bnVRLEKoh9NNFHqIE/p8JI2AbNBzwRexEmz+o7Fp32noGtwDaY5bDg7BSPnw9fYy BOm80g== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41gy5a4us4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Sep 2024 10:04:18 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 48CA4HfU002919 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Sep 2024 10:04:17 GMT Received: from [10.204.67.70] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 12 Sep 2024 03:04:08 -0700 Message-ID: Date: Thu, 12 Sep 2024 15:34:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P Content-Language: en-US To: Bjorn Andersson CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20240911100813.338-1-quic_mukhopad@quicinc.com> <20240911100813.338-6-quic_mukhopad@quicinc.com> From: Soutrik Mukhopadhyay In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ToRsyldAUBe2tOlGmBRtpMvihP0rxCBe X-Proofpoint-ORIG-GUID: ToRsyldAUBe2tOlGmBRtpMvihP0rxCBe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409120070 On 9/12/2024 1:32 AM, Bjorn Andersson wrote: > On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: >> The Qualcomm SA8775P platform comes with a DisplayPort controller >> with a different base offset than the previous SoCs, >> add support for this in the DisplayPort driver. >> >> Signed-off-by: Soutrik Mukhopadhyay >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index e1228fb093ee..e4954fd99eb0 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -118,6 +118,12 @@ struct msm_dp_desc { >> bool wide_bus_supported; >> }; >> >> +static const struct msm_dp_desc sa8775p_dp_descs[] = { >> + { .io_start = 0xaf54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, >> + { .io_start = 0xaf5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true }, > Why is this list incomplete? > > Regards, > Bjorn Do you mean to add for mdss_1 as well? We only added dp controllers for mdss_0 as we plan to validate and enable only these. > >> + {} >> +}; >> + >> static const struct msm_dp_desc sc7180_dp_descs[] = { >> { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, >> {} >> @@ -162,6 +168,7 @@ static const struct msm_dp_desc x1e80100_dp_descs[] = { >> }; >> >> static const struct of_device_id dp_dt_match[] = { >> + { .compatible = "qcom,sa8775p-dp", .data = &sa8775p_dp_descs }, >> { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_descs }, >> { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_descs }, >> { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_descs }, >> -- >> 2.17.1 >>