From: YueHaibing <yuehaibing@huawei.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: <marcel@holtmann.org>, <johan.hedberg@gmail.com>,
<linux-bluetooth@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<pmenzel@molgen.mpg.de>
Subject: Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()
Date: Fri, 28 Jul 2023 11:29:41 +0800 [thread overview]
Message-ID: <a452560c-97b3-ed32-e9a5-ac9f8f3ba14c@huawei.com> (raw)
In-Reply-To: <CABBYNZ+Fxmkxg3qQMABt-1DcvhMcUnqsOrwGgHXMQum5ezF82Q@mail.gmail.com>
On 2023/7/28 6:21, Luiz Augusto von Dentz wrote:
> Hi Yue,
>
> On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>>
>> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
>> and never be implemented.
>
> The commit information above shall be added with Fixes: tag so it can
> be properly backported, etc.
Ok, v3 on the way.
>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> v2: fix SOB and update commit log
>> ---
>> net/bluetooth/amp.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
>> index 832764dfbfb3..97c87abd129f 100644
>> --- a/net/bluetooth/amp.h
>> +++ b/net/bluetooth/amp.h
>> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>>
>> int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>>
>> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>> void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>> void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>> void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
>> --
>> 2.34.1
>>
>
>
prev parent reply other threads:[~2023-07-28 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 1:39 Yue Haibing
2023-07-27 22:21 ` Luiz Augusto von Dentz
2023-07-28 3:29 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a452560c-97b3-ed32-e9a5-ac9f8f3ba14c@huawei.com \
--to=yuehaibing@huawei.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®